Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint error on floating promises #8198

Merged
merged 3 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
/* eslint-disable no-restricted-syntax */
/* eslint-env node */
const process = require('process');

const lintTypes = !!process.env.AGORIC_ESLINT_TYPES;

const deprecatedForLoanContract = [
['currency', 'brand, asset or another descriptor'],
Expand Down Expand Up @@ -34,26 +31,24 @@ const deprecatedTerminology = Object.fromEntries(
module.exports = {
root: true,
parser: '@typescript-eslint/parser',
parserOptions: lintTypes
? {
// this is not yet compatible with eslint lsp so it's conditioned on AGORIC_ESLINT_TYPES
EXPERIMENTAL_useProjectService: true,
sourceType: 'module',
project: [
'./packages/*/tsconfig.json',
'./packages/*/tsconfig.json',
'./packages/wallet/*/tsconfig.json',
'./tsconfig.json',
],
tsconfigRootDir: __dirname,
extraFileExtensions: ['.cjs'],
}
: undefined,
parserOptions: {
// this is not yet compatible with eslint lsp so it's conditioned on AGORIC_ESLINT_TYPES
EXPERIMENTAL_useProjectService: true,
sourceType: 'module',
project: [
'./packages/*/tsconfig.json',
'./packages/*/tsconfig.json',
'./packages/wallet/*/tsconfig.json',
'./tsconfig.json',
],
tsconfigRootDir: __dirname,
extraFileExtensions: ['.cjs'],
},
plugins: ['@typescript-eslint', 'prettier'],
extends: ['@agoric'],
rules: {
'@typescript-eslint/prefer-ts-expect-error': 'warn',
'@typescript-eslint/no-floating-promises': lintTypes ? 'warn' : 'off',
'@typescript-eslint/no-floating-promises': 'error',
// so that floating-promises can be explicitly permitted with void operator
'no-void': ['error', { allowAsStatement: true }],

Expand Down
1 change: 1 addition & 0 deletions packages/SwingSet/misc-tools/extract-xs-snapshot.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import '@endo/init';
import process from 'process';
Expand Down Expand Up @@ -54,7 +55,7 @@
const { snapPos, hash } = info;
const snapshot = snapStore.loadSnapshot(vatIDToExtract);
const fn = `${vatIDToExtract}-${snapPos}-${hash}.xss`;
E.when(fs.promises.writeFile(fn, snapshot), () =>

Check warning on line 58 in packages/SwingSet/misc-tools/extract-xs-snapshot.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
console.log(`wrote snapshot to ${fn}`),
);
}
1 change: 1 addition & 0 deletions packages/SwingSet/test/test-vat-timer.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
// eslint-disable-next-line import/order
import { test } from '../tools/prepare-test-env-ava.js';

Expand Down Expand Up @@ -268,8 +269,8 @@
const whenNobrand = 123n;
const delayNobrand = 123n;
ts.setWakeup(whenNobrand, handler);
ts.wakeAt(whenNobrand);

Check warning on line 272 in packages/SwingSet/test/test-vat-timer.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
ts.delay(delayNobrand);

Check warning on line 273 in packages/SwingSet/test/test-vat-timer.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
ts.makeRepeater(delayNobrand, delayNobrand);
ts.repeatAfter(delayNobrand, delayNobrand, handler);
ts.makeNotifier(delayNobrand, delayNobrand);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import test from 'ava';
import '@endo/init/debug.js';
import tmp from 'tmp';
Expand Down Expand Up @@ -59,7 +60,7 @@
const { commit } = hostStorage;
const initOpts = { addComms: false, addVattp: false, addTimer: false };
await initializeSwingset(config, [], kernelStorage, initOpts);
commit();

Check warning on line 63 in packages/SwingSet/test/transcript/test-state-sync-reload.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

const { runtimeOptions } = t.context.data;
const c1 = await makeSwingsetController(kernelStorage, {}, runtimeOptions);
Expand All @@ -82,7 +83,7 @@
t.is(res, i);
}

commit();

Check warning on line 86 in packages/SwingSet/test/transcript/test-state-sync-reload.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
await c1.shutdown();

const exporter = makeSwingStoreExporter(dbDir);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import test from 'ava';
import '@endo/init/debug.js';
import { initSwingStore } from '@agoric/swing-store';
Expand Down Expand Up @@ -117,12 +118,12 @@
const { commit } = hostStorage;
const initOpts = { addComms: false, addVattp: false, addTimer: false };
await initializeSwingset(config, [], kernelStorage, initOpts);
commit();

Check warning on line 121 in packages/SwingSet/test/transcript/test-transcript-entries.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

let c;
const restart = async () => {
if (c) {
commit();

Check warning on line 126 in packages/SwingSet/test/transcript/test-transcript-entries.js

View workflow job for this annotation

GitHub Actions / lint-primary

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
await c.shutdown();
}
const { runtimeOptions } = t.context.data;
Expand Down
1 change: 1 addition & 0 deletions packages/agoric-cli/src/bin-agops.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env node
// @ts-check
// @jessie-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

/* global fetch, setTimeout */

Expand Down
1 change: 1 addition & 0 deletions packages/agoric-cli/src/start.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/* global process setTimeout */
import chalk from 'chalk';
import { createHash } from 'crypto';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/** @file Bootstrap test integration vaults with smart-wallet */
import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';

Expand Down
1 change: 1 addition & 0 deletions packages/boot/test/bootstrapTests/test-zcf-upgrade.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';
import bundleSource from '@endo/bundle-source';
Expand Down
1 change: 1 addition & 0 deletions packages/cosmic-swingset/scripts/clean-core-eval.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#! /usr/bin/env node
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import '@endo/init/debug.js';
import * as farExports from '@endo/far';
import { isEntrypoint } from '../src/helpers/is-entrypoint.js';
Expand Down
1 change: 1 addition & 0 deletions packages/governance/src/binaryVoteCounter.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { makePromiseKit } from '@endo/promise-kit';
import { makeExo, keyEQ, makeScalarMapStore } from '@agoric/store';
import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/governance/src/contractGovernance/paramManager.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { Far, passStyleOf } from '@endo/marshal';
import { AmountMath } from '@agoric/ertp';
import { assertKeywordName } from '@agoric/zoe/src/cleanProposal.js';
Expand Down
1 change: 1 addition & 0 deletions packages/governance/src/multiCandidateVoteCounter.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { keyEQ, makeExo, makeScalarMapStore } from '@agoric/store';
import { E } from '@endo/eventual-send';
import { makePromiseKit } from '@endo/promise-kit';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';
import '@agoric/zoe/exported.js';
import { E } from '@endo/eventual-send';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';
import { makeStoredPublishKit } from '@agoric/notifier';
import {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';

import { makeNotifierFromAsyncIterable } from '@agoric/notifier';
Expand Down
1 change: 1 addition & 0 deletions packages/internal/src/queue.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @jessie-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import { makePromiseKit } from '@endo/promise-kit';

Expand All @@ -16,7 +17,7 @@
}
const [thunk, resolve, reject] = queue[0];
// Run the thunk in a new turn.
Promise.resolve()

Check warning on line 20 in packages/internal/src/queue.js

View workflow job for this annotation

GitHub Actions / lint-rest

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator. A rejection handler that is not a function will be ignored
.then(thunk)
// Resolve or reject our caller with the thunk's value.
.then(resolve, reject)
Expand Down
1 change: 1 addition & 0 deletions packages/pegasus/src/proposals/core-proposal.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { E, Far } from '@endo/far';
import { makeNameHubKit } from '@agoric/vats/src/nameHub.js';
import { observeIteration, subscribeEach } from '@agoric/notifier';
Expand Down
1 change: 1 addition & 0 deletions packages/pegasus/test/test-peg.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import path from 'path';
Expand Down
1 change: 1 addition & 0 deletions packages/smart-wallet/test/gameAssetContract.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/** @file illustrates using non-vbank assets */
/* eslint @typescript-eslint/no-floating-promises: "warn" */

// deep import to avoid dependency on all of ERTP, vat-data
import { AmountShape } from '@agoric/ertp';
Expand Down
1 change: 1 addition & 0 deletions packages/smart-wallet/test/test-addAsset.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';
import { E, Far } from '@endo/far';
import { buildRootObject as buildBankVatRoot } from '@agoric/vats/src/vat-bank.js';
Expand Down
1 change: 1 addition & 0 deletions packages/solo/public/main.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* global setTimeout */
/* eslint @typescript-eslint/no-floating-promises: "warn" */
// NOTE: Runs outside SES

/* global WebSocket fetch document window walletFrame localStorage */
Expand Down
1 change: 1 addition & 0 deletions packages/solo/src/captp.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { E, makeCapTP } from '@endo/captp';
import { Far } from '@endo/marshal';

Expand Down
1 change: 1 addition & 0 deletions packages/solo/src/chain-cosmos-sdk.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* global clearTimeout setTimeout Buffer */
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import path from 'path';
import fs from 'fs';
import url from 'url';
Expand Down
1 change: 1 addition & 0 deletions packages/solo/src/vat-http.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { makeNotifierKit } from '@agoric/notifier';
import { makeCache } from '@agoric/cache';
import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/solo/test/captp-fixture.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* global process setTimeout */
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { spawn } from 'child_process';
import WebSocket from 'ws';
import { makeCapTP, E } from '@endo/captp';
Expand Down
1 change: 1 addition & 0 deletions packages/swingset-liveslots/src/liveslots.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import {
Remotable,
passStyleOf,
Expand Down Expand Up @@ -1601,7 +1602,7 @@
// *not* directly wait for the userspace function to complete, nor for
// any promise it returns to fire.
const p = Promise.resolve(delivery).then(unmeteredDispatch);
p.finally(() => (complete = true));

Check warning on line 1605 in packages/swingset-liveslots/src/liveslots.js

View workflow job for this annotation

GitHub Actions / lint-rest

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

// Instead, we wait for userspace to become idle by draining the
// promise queue. We clean up and then examine/return 'p' so any
Expand Down
1 change: 1 addition & 0 deletions packages/wallet/api/src/lib-wallet.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

/**
* This file defines the wallet internals without dependency on the ag-solo on
Expand Down
1 change: 1 addition & 0 deletions packages/wallet/api/src/wallet.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

/**
* This file defines the vat launched by the spawner in the ../deploy.js script.
Expand Down
1 change: 1 addition & 0 deletions packages/wallet/api/test/test-lib-wallet.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';

import bundleSource from '@endo/bundle-source';
Expand Down
1 change: 1 addition & 0 deletions packages/xsnap/src/avaXS.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/* avaXS - ava style test runner for XS

Usage:
Expand Down Expand Up @@ -386,7 +387,7 @@

stats.total += results.total;
stats.pass += results.pass;
results.fail.forEach(info => stats.fail.push(info));

Check warning on line 390 in packages/xsnap/src/avaXS.js

View workflow job for this annotation

GitHub Actions / lint-rest

Prefer for...of instead of Array.forEach
}

console.log(stats.pass, 'tests passed');
Expand Down
1 change: 1 addition & 0 deletions packages/xsnap/src/xsnap.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* global process */
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/* eslint no-await-in-loop: ["off"] */

/**
Expand Down Expand Up @@ -151,7 +152,7 @@
sourceStream.pipe(destStream, { end: false });

done = finished(sourceStream);
done.catch(noop).then(() => sourceStream.unpipe(destStream));

Check warning on line 155 in packages/xsnap/src/xsnap.js

View workflow job for this annotation

GitHub Actions / lint-rest

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
};

return harden({
Expand Down Expand Up @@ -257,7 +258,7 @@
await loadSnapshotHandler?.afterSpawn(snapshotLoadStream);

if (loadSnapshotHandler) {
vatExit.promise.catch(noop).then(() => {

Check warning on line 261 in packages/xsnap/src/xsnap.js

View workflow job for this annotation

GitHub Actions / lint-rest

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
if (loadSnapshotHandler) {
const { cleanup } = loadSnapshotHandler;
loadSnapshotHandler = undefined;
Expand Down Expand Up @@ -457,7 +458,7 @@
const handle = await fs.open(snapPath, 'w+');
// @ts-expect-error 'close' event added in Node 15.4
handle.on('close', () => {
fs.unlink(snapPath);

Check warning on line 461 in packages/xsnap/src/xsnap.js

View workflow job for this annotation

GitHub Actions / lint-rest

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
});
sourceStream = handle.createReadStream();
finished(output).finally(() => sourceStream.destroy());
Expand Down
1 change: 1 addition & 0 deletions packages/xsnap/src/xsrepl.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/* global process */
/* We make exceptions for test code. This is a test utility. */
/* eslint no-await-in-loop: ["off"] */
Expand Down
1 change: 1 addition & 0 deletions packages/xsnap/test/fixture-xsnap-script.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/* global issueCommand */
(async () => {
issueCommand(new TextEncoder().encode('Hello, World!').buffer);
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractFacet/zcfMint.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { AmountMath } from '@agoric/ertp';
import { prepareExoClass } from '@agoric/vat-data';
import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractFacet/zcfSeat.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import {
makeScalarBigWeakMapStore,
prepareExoClass,
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractFacet/zcfZygote.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { AssetKind } from '@agoric/ertp';
import { assertPattern, mustMatch } from '@agoric/store';
import {
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractSupport/priceAuthority.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/// <reference types="@agoric/time/src/types.d.ts" />

import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractSupport/priceAuthorityInitial.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// @ts-check
// @jessie-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import { E } from '@endo/far';
import { Far } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contractSupport/zoeHelpers.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { mustMatch, keyEQ } from '@agoric/store';
import { E } from '@endo/eventual-send';
import { makePromiseKit } from '@endo/promise-kit';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/auction/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { E } from '@endo/eventual-send';
import { mustMatch } from '@endo/patterns';
import { Far } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/callSpread/payoffHandler.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import './types.js';

import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/callSpread/pricedCallSpread.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import './types.js';

import { makePromiseKit } from '@endo/promise-kit';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/oracle.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { assert, Fail } from '@agoric/assert';
import { Far } from '@endo/marshal';
import { AmountMath } from '@agoric/ertp';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/priceAggregator.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/// <reference types="@agoric/time/src/types.d.ts" />

import { Fail, q } from '@agoric/assert';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/contracts/sellItems.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { Far } from '@endo/marshal';
import { Nat } from '@endo/nat';
import { AmountMath } from '@agoric/ertp';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/zoeService/instanceAdminStorage.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import {
canBeDurable,
makeScalarBigSetStore,
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/zoeService/startInstance.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { E } from '@endo/eventual-send';
import { passStyleOf } from '@endo/marshal';
import {
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/zoeService/zoe.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @jessie-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

/**
* Zoe uses ERTP, the Electronic Rights Transfer Protocol
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/src/zoeService/zoeSeat.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { prepareDurablePublishKit, SubscriberShape } from '@agoric/notifier';
import { E } from '@endo/eventual-send';
import { M, prepareExoClassKit } from '@agoric/vat-data';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import { E } from '@endo/eventual-send';
import { Far } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/types.test-d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
/**
* @file uses .ts syntax to be able to declare types (e.g. of kit.creatorFacet as {})
* because "there is no JavaScript syntax for passing a a type argument"
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/contracts/loan/helpers.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import '@agoric/swingset-liveslots/tools/prepare-test-env.js';

import path from 'path';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/contracts/loan/test-borrow.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @ts-nocheck
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';
import '../../../../exported.js';

Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/contracts/test-atomicSwap.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import path from 'path';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/contracts/test-coveredCall.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import path from 'path';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test as unknownTest } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import path from 'path';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/test-fakePriceAuthority.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/test-manualTimer.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/zcf/test-zcf.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import { Far } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/test/unitTests/zoe/test-escrowStorage.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';
import { AmountMath, makeIssuerKit, AssetKind } from '@agoric/ertp';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { test } from '@agoric/swingset-vat/tools/prepare-test-env-ava.js';

import { Far } from '@endo/marshal';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/tools/manualPriceAuthority.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// @jessie-check
/* eslint @typescript-eslint/no-floating-promises: "warn" */

import { AmountMath, makeIssuerKit, AssetKind } from '@agoric/ertp';
import { E } from '@endo/eventual-send';
Expand Down
1 change: 1 addition & 0 deletions packages/zoe/tools/scriptedPriceAuthority.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint @typescript-eslint/no-floating-promises: "warn" */
import { AmountMath, makeIssuerKit, AssetKind } from '@agoric/ertp';
import { E } from '@endo/eventual-send';
import { Far } from '@endo/marshal';
Expand Down
Loading