-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-provision smart wallet #8574
Conversation
High-level comments: Impressive plumbing to get that all wired through! I'm a little concerned about the additional complexity for trying to suppress duplicate auto-provisioning within the same transaction. We're already resigned to having duplicate auto-provision requests in different blocks while the first request is still queued, so maybe that's an acceptable way to handle the now-impossible case of multiple wallet messages in a single transaction? It would be great if we could drop the customization of |
It felt wrong for the msg server to assume all unprovisioned smart wallet messages allowed by the ante handler were eligible for auto provisioning, seeing how decoupled they are, but I suppose that's a fair assumption to make. I do agree it would simplify the logic, and maybe with sufficient comments in both directions it'd be acceptable. |
I removed the ctx logic. In hindsight, it's much better because it wouldn't be needed anyway if/when we implement marking of pending provisions. We could potentially re-use the egress marking of explicit provision to implement this marking now. |
cf6f4d2
to
cdbaa77
Compare
Addressed feedback, then fixed-up: cf6f4d2...cdbaa77 |
cdbaa77
to
6b5dcae
Compare
This reverts commit 291b9d0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much simpler now! But a few remaining cleanups. Should be quick.
Rolled into #8623 |
closes: #8558
Description
This change implements smart wallet auto-provisioning by:
It does not mark whether a smart wallet provision is pending, and as such may result in provision beans fees being charged multiple times if smart wallet messages are submitted and included in new blocks before the provision message is executed by swingset.
This PR includes some necessary changes to the upgrade handler:
Security Considerations
The provision step in swingset does not change and still provides a nominal amount of IST during provisioning, for each provision message handled. As such the beans amount charged for auto-provisioning a wallet should be higher than the nominal amount transferred from the provision pool.
Scaling Considerations
None
Documentation Considerations
TBD
Testing Considerations
TBD
Upgrade Considerations
Requires a new chain software consensus upgrade.
Added required logic to the upgrade handler for the new fee.