Auto-provision smart wallet #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/8558-auto-provision
branch
from
48d8ae7
to
cd19304
Compare
michaelfig
approved these changes
Dec 6, 2023
golang/cosmos/app/app.go
Outdated
| m := swingsetkeeper.NewMigrator(app.SwingSetKeeper) | ||
| err = m.MigrateParams(ctx) | ||
| if err != nil { | ||
| return fromVm, err |
There was a problem hiding this comment.
Why return fromVm? The prior return does mvm even on error. Maybe consider leaving an explanatory comment?
There was a problem hiding this comment.
I assumed that when returning an error, the version map should be the "default" value, in this case the "from version map" even though the module manager's migration logic ran its course. I guess it's more a question of what is the best conceptual return value in this case, since if an error is returned, it panics.
There was a problem hiding this comment.
Use mvm since it's less confusing and doesn't matter.
packages/deployment/upgrade-test/upgrade-test-scripts/unreleased-upgrade/actions.test.js
Outdated
Show resolved
Hide resolved
mhofman
force-pushed
the
mhofman/8558-auto-provision
branch
from
892c6d3
to
d9cee0a
Compare
mhofman
added a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8558
refs: #8574
Best reviewed commit-by-commit
Description
This change implements smart wallet auto-provisioning by:
It does not mark whether a smart wallet provision is pending, and as such may result in provision beans fees being charged multiple times if smart wallet messages are submitted and included in new blocks before the provision message is executed by swingset.
This PR includes some necessary changes to the upgrade handler:
Security Considerations
The provision step in swingset does not change and still provides a nominal amount of IST during provisioning, for each provision message handled. As such the beans amount charged for auto-provisioning a wallet should be higher than the nominal amount transferred from the provision pool.
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
CheckAdmissibilityunit test infrastructure that could be extended to directly test the auto-provision fee behavior.msg_serverunit test infrastructure that could be extended to directly test the generation of auto-provision action.Upgrade Considerations
Requires a new chain software consensus upgrade. This change is planned to be included in agoric-upgrade-13, and was actually first implemented against that release branch in #8574. The rebase was clean except for the renamed upgrade-test.
Added required logic to the upgrade handler for the new fee.