rebase/cherry-pick commits for upgrade 13 #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's only for installing the bin and importing that bin module
refactor clientSupport to not depend on agoric-cli package
* fix(inter-protocol): brands in CLI need not start with A-Z * test(inter-protocol): clientSupport for initial non-uppercase * fixup! fix(inter-protocol): brands in CLI need not start with A-Z --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
The backport referenced above has the agd process hang around after halting. Wrote a wrapper utility which scans stderr for the halt application message, interrupts the process, then propagates its error signal. Conventional shell scripting is not up to the challenge of expressing this behavior.
…#305" This reverts commit efcc3b0. We decided to roll back the problematic change (agoric-labs/cosmos-sdk#305).
feat: update ibc-go to v4, adapt packages and API
…t-found fix(cli): handle not found error in vstorage requests
needs instance based on --pair
fix(casting): dont crash on bad capdata
fix(agops): fix continuing id lookup in oracle setPrice
mhofman
force-pushed
the
mhofman/cherry-pick-upgrade-13
branch
from
ef2163e
to
0e894b8
Compare
…grade Remove upgrade-test BOOTSTRAP_MODE=test
fix(casting): properly follow an unpopulated node
Add a new API to the exporter, `exporter.getHostKV(key)`, so that the cosmic-swingset state-sync exporter process can query `host.height` without accidentally creating a read-write transaction too. refs #8523
Exporting a state-sync snapshot is a read-only operation, and is
designed to run "in the background", i.e. in parallel with normal
mutating operations. It accomplishes this by opening a read-only
transaction right away, effectively capturing a snapshot of the SQLite
database state, to insulate the export process from ongoing writes by
the execution host.
The cosmic-swingset exporter starts with a query of `host.height`, to
confirm that the database has not already advanced to a new block
before this snapshot/read-transaction can be taken.
Previously, this query worked by using `openSwingStore`, and then
calling `hostStorage.hostKVStore.get('host.height')`. This had two
problems:
* TOCTTOU: the `hostKVStore.get` used a different DB connection (and
different txn) than the exporter, so it might return a different
height, negating the accuracy of the consistency check
* read-write txn: `openSwingStore` creates a read-*write* txn, even
when merely opening the DB (because it might need to create the
initial tables). This txn is closed right away, before
`openSwingStore()` returns, so it did not present a threat to
ongoing operations. But if the exporter was created while the
ongoing execution side already had its own read-write txn
open (e.g. while `controller.run()` was running), then it would
fail, and `makeSwingStoreExporter` would fail with `SQLITE_BUSY`
Instead, we take advantage of the new `swingStoreExporter.getHostKV()`
API, and use *it* to fetch `host.height`. Unlike the normal
swingstore, the swingstore-exporter refrains from creating read-write
transactions entirely. So the cosmic-swingset export code can safely
query the height without fear of getting the wrong value or failing
because of an ongoing write transaction.
We think this should fix the SQLITE_BUSY errors.
refs #8523
…lock fix: export state-sync snapshot without a DB write-lock
feat: allow clawback vesting accounts to return grants
Auto-provision smart wallet
* feat(cosmos): un-wire x/crisis * fixup! feat(cosmos): un-wire x/crisis --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mhofman
force-pushed
the
mhofman/cherry-pick-upgrade-13
branch
from
0e894b8
to
457beb3
Compare
toliaqat
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Look great! Thanks @mhofman for making it happen.
Verified that the PRs are ones referenced in the upgrade-13 project page.
Verified that these changes will not impact Vats code.
Replicated cherry-pick of the upgrade-13 project PRs and found no difference between my replication and this PR.
🚀
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR staging rebases of some master branch PRs towards an upgrade-13.
The following issue and associated PRs have been cherry picked:
/wallet/bridge.html#8533These changes don't have any modifications to runtime files included in the vat bundles.
It was performed with the following interactive rebase onto the
dev-upgrade-13branch, and some minor conflict resolutions:For reference, the non-pruned rebase-todo of the master commits since the one generated for upgrade-12 (#8510):
rebase-todo since upgrade-12