Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agoric-upgrade-13 #8588

Merged
merged 3 commits into from
Dec 1, 2023
Merged

agoric-upgrade-13 #8588

merged 3 commits into from
Dec 1, 2023

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Nov 30, 2023

refs: #8578

Description

This prepares the dev-upgrade-13 branch for the next chain software upgrade, agoric-upgrade-13. The branch is based on release-mainnet1B after agoric-upgrade-12. This PR is the equivalent of #8587 but for the the agoric-upgrade-13 release.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

Docker upgrade-test Readme updated with the same changes as #8587

Testing Considerations

Docker upgrade tests coverage should be sufficient

Upgrade Considerations

This sets up the upgrade tests for the next chain software upgrade. Because of the different image naming, cherry-picking from master may require manual conflict resolution.

@mhofman mhofman added the force:integration Force integration tests to run on PR label Nov 30, 2023
@mhofman mhofman changed the title Mhofman/8578 upgrade 13 name agoric-upgrade-13 Nov 30, 2023
@mhofman mhofman marked this pull request as ready for review November 30, 2023 23:51
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though you may want to wait for #8587 to land so you can re-use the actual commits to master

@mhofman
Copy link
Member Author

mhofman commented Dec 1, 2023

LGTM. Though you may want to wait for #8587 to land so you can re-use the actual commits to master

The commits are slightly different. The plan is to have master and the release branch diverge here. However I'll wait to update the base branch first.

@turadg
Copy link
Member

turadg commented Dec 1, 2023

The plan is to have master and the release branch diverge here

I presumed you would not want the documentation to diverge

@mhofman
Copy link
Member Author

mhofman commented Dec 1, 2023

I presumed you would not want the documentation to diverge

Ah yeah that commit is the same

@mhofman mhofman changed the base branch from release-mainnet1B to dev-upgrade-13 December 1, 2023 17:11
@mhofman mhofman force-pushed the mhofman/8578-upgrade-13-name branch from 1508379 to 6426775 Compare December 1, 2023 17:13
@mhofman mhofman merged commit 5fe83be into dev-upgrade-13 Dec 1, 2023
58 checks passed
@mhofman mhofman deleted the mhofman/8578-upgrade-13-name branch December 1, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants