-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: continuing offers in orchestrate async-flows #9679
Merged
Merged
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc12cbd - Browse repository at this point
Copy the full SHA bc12cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8330fba - Browse repository at this point
Copy the full SHA 8330fbaView commit details -
chore: chain facades create child node per account
- previously, each orch account was given the contracts storage node. this creates a child node per account - refs #9066, helping ensure orch account addresses are available for smart-wallet clients. left some suggestions in code comments for further improvements
Configuration menu - View commit details
-
Copy full SHA for 3ba1e59 - Browse repository at this point
Copy the full SHA 3ba1e59View commit details -
Configuration menu - View commit details
-
Copy full SHA for f425141 - Browse repository at this point
Copy the full SHA f425141View commit details -
chore: getPublicTopics and asContinuingOffer return vows
- update PublicTopic.storagePath on async-flow endowments to return a string instead of a promise. Uses asVow with async function since it's reasonable to assume the remote call will resolve promptly (in the same run) - update asContinuingOffer to return a vow and unwrap the result of getPublicTopic since this is also a vow. same promptness considerations mentioned above apply - closes: #9673
Configuration menu - View commit details
-
Copy full SHA for 3bb15ba - Browse repository at this point
Copy the full SHA 3bb15baView commit details -
- seem like it was missed in #9664, but not caught since this job runs after merges to master
Configuration menu - View commit details
-
Copy full SHA for 033a2f8 - Browse repository at this point
Copy the full SHA 033a2f8View commit details
Commits on Jul 11, 2024
-
test: e2e test of basic-flows.contract.js
- tests a contract that uses orchestrate/async-flow in the multichain-testing environment
Configuration menu - View commit details
-
Copy full SHA for 8d8820b - Browse repository at this point
Copy the full SHA 8d8820bView commit details -
- fixes changed parameter from #9662 - improves test to print delegate offer result error on failure
Configuration menu - View commit details
-
Copy full SHA for b7a9ed3 - Browse repository at this point
Copy the full SHA b7a9ed3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.