test: continuing offers in orchestrate async-flows #9679
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,4 @@ | |
| .yarn/* | ||
| !.yarn/patches/* | ||
| revise-chain-info* | ||
| start* | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| import anyTest from '@endo/ses-ava/prepare-endo.js'; | ||
| import type { TestFn } from 'ava'; | ||
| import { commonSetup, SetupContextWithWallets } from './support.js'; | ||
| import { makeDoOffer } from '../tools/e2e-tools.js'; | ||
| import { chainConfig, chainNames } from './support.js'; | ||
|
|
||
| const test = anyTest as TestFn<SetupContextWithWallets>; | ||
|
|
||
| const accounts = ['user1', 'user2', 'user3']; // one account for each scenario | ||
|
|
||
| const contractName = 'basicFlows'; | ||
| const contractBuilder = | ||
| '../packages/builders/scripts/orchestration/init-basic-flows.js'; | ||
|
|
||
| test.before(async t => { | ||
| const { deleteTestKeys, setupTestKeys, ...rest } = await commonSetup(t); | ||
| deleteTestKeys(accounts).catch(); | ||
| const wallets = await setupTestKeys(accounts); | ||
| t.context = { ...rest, wallets, deleteTestKeys }; | ||
|
|
||
| t.log('bundle and install contract', contractName); | ||
| await t.context.deployBuilder(contractBuilder); | ||
| const vstorageClient = t.context.makeQueryTool(); | ||
| await t.context.retryUntilCondition( | ||
| () => vstorageClient.queryData(`published.agoricNames.instance`), | ||
| res => contractName in Object.fromEntries(res), | ||
| `${contractName} instance is available`, | ||
| ); | ||
| }); | ||
|
|
||
| test.after(async t => { | ||
| const { deleteTestKeys } = t.context; | ||
| deleteTestKeys(accounts); | ||
| }); | ||
|
|
||
| const makeAccountScenario = test.macro({ | ||
| title: (_, chainName: string) => `Create account on ${chainName}`, | ||
| exec: async (t, chainName: string) => { | ||
| const config = chainConfig[chainName]; | ||
| if (!config) return t.fail(`Unknown chain: ${chainName}`); | ||
|
|
||
| const { | ||
| wallets, | ||
| provisionSmartWallet, | ||
| makeQueryTool, | ||
| retryUntilCondition, | ||
| } = t.context; | ||
|
|
||
| const vstorageClient = makeQueryTool(); | ||
|
|
||
| const wallet = accounts[chainNames.indexOf(chainName)]; | ||
| const wdUser1 = await provisionSmartWallet(wallets[wallet], { | ||
| BLD: 100n, | ||
| IST: 100n, | ||
| }); | ||
| t.log(`provisioning agoric smart wallet for ${wallets[wallet]}`); | ||
|
|
||
| const doOffer = makeDoOffer(wdUser1); | ||
| t.log(`${chainName} makeAccount offer`); | ||
| const offerId = `${chainName}-makeAccount-${Date.now()}`; | ||
|
|
||
| // FIXME we get payouts but not an offer result; it times out | ||
| // https://github.com/Agoric/agoric-sdk/issues/9643 | ||
| // chain logs shows an UNPUBLISHED result | ||
| const _offerResult = await doOffer({ | ||
| id: offerId, | ||
| invitationSpec: { | ||
| source: 'agoricContract', | ||
| instancePath: [contractName], | ||
| callPipe: [['makeOrchAccountInvitation']], | ||
| }, | ||
| offerArgs: { chainName }, | ||
| proposal: {}, | ||
| }); | ||
| t.true(_offerResult); | ||
| // t.is(await _offerResult, 'UNPUBLISHED', 'representation of continuing offer'); | ||
|
|
||
| // TODO fix above so we don't have to poll for the offer result to be published | ||
| // https://github.com/Agoric/agoric-sdk/issues/9643 | ||
| const currentWalletRecord = await retryUntilCondition( | ||
| () => | ||
| vstorageClient.queryData(`published.wallet.${wallets[wallet]}.current`), | ||
| ({ offerToPublicSubscriberPaths }) => | ||
| Object.fromEntries(offerToPublicSubscriberPaths)[offerId], | ||
| `${offerId} continuing invitation is in vstorage`, | ||
| ); | ||
|
|
||
| const offerToPublicSubscriberMap = Object.fromEntries( | ||
| currentWalletRecord.offerToPublicSubscriberPaths, | ||
| ); | ||
|
|
||
| const address = offerToPublicSubscriberMap[offerId]?.account | ||
| .split('.') | ||
| .pop(); | ||
| t.log('Got address:', address); | ||
| t.regex( | ||
| address, | ||
| new RegExp(`^${config.expectedAddressPrefix}1`), | ||
| `address for ${chainName} is valid`, | ||
| ); | ||
|
|
||
| const latestWalletUpdate = await vstorageClient.queryData( | ||
| `published.wallet.${wallets[wallet]}`, | ||
| ); | ||
| t.log('latest wallet update', latestWalletUpdate); | ||
| t.like( | ||
| latestWalletUpdate.status, | ||
| { | ||
| id: offerId, | ||
| numWantsSatisfied: 1, | ||
| result: 'UNPUBLISHED', | ||
| error: undefined, | ||
| }, | ||
| 'wallet offer satisfied without errors', | ||
| ); | ||
| }, | ||
| }); | ||
|
|
||
| test.serial(makeAccountScenario, 'agoric'); | ||
| test.serial(makeAccountScenario, 'cosmoshub'); | ||
| test.serial(makeAccountScenario, 'osmosis'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was this discovered? do we need more CI for multichain-testing?
maybe that's why you're proposing it be in force-integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript error (warning?) in the test runner. We don't have
lint:typesincluded inlintsince it looks like:Aside - a UX consideration to keep in mind for orch devs working outside agoric-sdk. Aside, aside - appreciate the work you've personally done to make these warning virtually non-existent for the bulk of
agoric-sdk/packages/*There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please chime in on this thread to affirm or suggest an alternate plan