Update tags #53
Merged
Update tags #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the documentation and configuration files to reflect changes in the project. It also updates dependencies to their latest versions. Class diagram showing updated component registrationclassDiagram
class AuroSideNav {
+register(name: string)
}
class AuroSideNavItem {
+register(name: string)
}
class AuroSideNavSection {
+register(name: string)
}
note for AuroSideNav "Changed from RuntimeUtils.registerComponent"
note for AuroSideNavItem "Changed from RuntimeUtils.registerComponent"
note for AuroSideNavSection "Changed from RuntimeUtils.registerComponent"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
|
This reverts commit d002c7b.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide more context in the PR description about the rationale for key changes, particularly the removal of accordionVersion.js and the addition of new Rollup configs.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* **api:** add register static method [#82](https://github.com/AlaskaAirlines/auro-sidenav/issues/82) ([d002c7b](d002c7b))
* Revert "feat(api): add register static method [#82](https://github.com/AlaskaAirlines/auro-sidenav/issues/82)" ([46c986c](46c986c))
* **api:** add register static method [#82](https://github.com/AlaskaAirlines/auro-sidenav/issues/82) ([82a0913](82a0913))
…thub workflow files
rmenner
force-pushed
the
rmenner/update-tags-v2
branch
from
7790552 to
b621dea
Compare
|
Surge demo deployment failed! 😭 |
jordanjones243
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Seems like the work that was done in this release has been undone: v3.0.1...v3.1.0
Is there a reason for this or was this an accident?
Nice catch. I will make sure those updates are transferred over. |
- Update dependency versions
- `AuroSideNav.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-sidenav"` will still register this element to <auro-sidenav>
- `import { AuroSideNav } from '../src/auro-sidenav` wont register this element until `AuroSideNav.register` gets called
- Same changes on `AuroSideNavItem` and `AuroSideNavSection`
- Fixed the typo on Recommended Use and Version Control: `clement` -> `element`
jordanjones243
requested changes
Dec 24, 2024
jordanjones243
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
linking missing version tags
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update documentation, dependencies, tests, and configuration files. Update the contributing guidelines to clarify the process for submitting issues and pull requests. Update the code of conduct to remove specific contact information. Update the changelog to reflect the latest changes. Update the package version to 3.1.0.
Documentation:
Tests:
Chores: