UI Refinements #2630
Merged
UI Refinements #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of longer messages (like expections) we want to read the whole words.
tvdeyen
force-pushed
the
ui-refinements
branch
from
d9a7c3c to
e6ef793
Compare
The handle should be visually seperated from the content of the header in order to be clearly be part of the UI.
The current size is too large for the space we have in this area. Also the disabled style is redundant now that we use icon_button.
Since all toolbar buttons are flex items, this should be inline flex.
The items are not evenly aligned otherwise
The table row was set this high in order to be able to place the icon buttons into the tools column. But this removes too much screen estate. Adjusting the paddings to the icons still align nicely while reducing the height to a more balanced layout.
The hint is already present in the info dialog. Also the toolbar icons are all buttons (or selects), but never just info icons.
tvdeyen
force-pushed
the
ui-refinements
branch
from
e6ef793 to
8b219a7
Compare
The status is already available in the info dialog and displayed inline in the page lists.
The page_info partial was holding the page status icons while the page_status partial was holding page infos. Exchanging the names should clarify that confusion.
They were too small and it was not easy to distinguish normal pages from locked pages.
We should not use the button with label (tooltip) for this behavior, but let the button have it.
tvdeyen
force-pushed
the
ui-refinements
branch
from
950955e to
5bfa90f
Compare
sascha-karnatz
approved these changes
Dec 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist