Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullify Ingredients::Page on Page destroy #2829

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Apr 10, 2024

When we delete a page, page ingredients that point to that page should be nullified.

When we delete a page, page ingredients that point to that page should
be nullified.
@mamhoff mamhoff requested a review from a team as a code owner April 10, 2024 19:15
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (8fb247c) to head (d183256).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
+ Coverage   95.84%   95.86%   +0.01%     
==========================================
  Files         227      227              
  Lines        6185     6186       +1     
==========================================
+ Hits         5928     5930       +2     
+ Misses        257      256       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamhoff
Copy link
Contributor Author

mamhoff commented Apr 10, 2024

There is a commit in 6.1-stable that does the same for EssencePages: 35e0a3c

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using the database for this? I've never used this before, but maybe worth looking into?

app/models/alchemy/page.rb Show resolved Hide resolved
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels Apr 10, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 4df4762 into AlchemyCMS:main Apr 10, 2024
37 checks passed
@alchemycms-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
7.0-stable
7.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants