Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullify Ingredients::Page on Page destroy #2829

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Nullify Ingredients::Page on Page destroy #2829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/alchemy/page.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ class Page < BaseRecord
has_one :draft_version, -> { drafts }, class_name: "Alchemy::PageVersion"
has_one :public_version, -> { published }, class_name: "Alchemy::PageVersion", autosave: -> { persisted? }

has_many :page_ingredients, class_name: "Alchemy::Ingredients::Page", foreign_key: :related_object_id, dependent: :nullify
tvdeyen marked this conversation as resolved.
Show resolved Hide resolved

before_validation :set_language,
if: -> { language.nil? }

Expand Down
8 changes: 8 additions & 0 deletions spec/models/alchemy/page_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,14 @@ module Alchemy
it "destroys elements along with itself" do
expect { page.destroy! }.to change(Alchemy::Element, :count).from(3).to(0)
end

context "with a page ingredient pointing to the page" do
let!(:ingredient) { create(:alchemy_ingredient_page, page: page) }

it "nullifies the foreign key on the ingredient" do
expect { page.destroy! }.to change { ingredient.reload.related_object_id }.from(page.id).to(nil)
end
end
end
end

Expand Down