Skip to content

Commit

Permalink
Move trg.errorcleanup role to before_GO_ERROR (#626)
Browse files Browse the repository at this point in the history
Since in a healthy end of run sequence we perform end of trigger at before_STOP_ACTIVITY, there is no reason to perform it later in the sequence in case of going to ERROR.
I confirmed with the trigger and reconstruction experts that the change is OK.
  • Loading branch information
knopers8 authored Nov 30, 2023
1 parent 4e2914a commit 3ab1371
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion workflows/readout-dataflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,7 @@ roles:
- name: errorcleanup
call:
func: trg.Cleanup()
trigger: after_GO_ERROR-100
trigger: before_GO_ERROR
timeout: "{{ trg_cleanup_timeout }}"
critical: false
- name: destroycleanup
Expand Down

0 comments on commit 3ab1371

Please sign in to comment.