Make sure that trigger end time is earlier than run end time #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved trd.Cleanup() from after_GO_ERROR-100 to enter_ERROR to allow ECS set run_end_time_ms upon after_GO_ERROR, where it is required by ccdb.RunStop(). The move preserves the order that the plugins are executed. In particular, trg.Cleanup() is still before dcs.Cleanup(), in case it is important to preserve. - moved ccdb.RunStop() from enter_ERROR to after_GO_ERROR, so it can be later than trg.Cleanup()
knopers8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will remove the WIP after I test it.