WIP OCTRL-917 add public "bookkept" flag to enable bookkeeping of an env #662
Conversation
knopers8
changed the title
| @@ -1,5 +1,6 @@ | |||
| name: !public readout-dataflow | |||
| description: !public "Main workflow template for ALICE data taking" | |||
| bookkept: !public "true" | |||
There was a problem hiding this comment.
@knopers8 does this new var need to be marked as public ? IIRC, that's to control if the var is displayed in the GUI or not as a widget.
There was a problem hiding this comment.
i assumed it could be, since I consider it a high-level property of a workflow template and it could be displayed in one way or another whether the environments started with it are bookkept.
There was a problem hiding this comment.
I'm not sure it should be a widget at all, and in any case, this is not the syntax that would make it a widget. It's not even clear that it's a static property of the workflow. My understanding was that it's not up to the user to choose whether an environment will be bookkept or not, but that it depends on some combination of traits of the workflow itself, and of its runtime configuration. In any case, I don't think this is the syntax we want.
@vascobarroso under which conditions should an environment be bookkept / not be bookkept?
There was a problem hiding this comment.
We should store in bookkeeping readout-dataflow envs.
We should NOT store in bookkeeping:
- CRU related actions
- qc-server workflows
There was a problem hiding this comment.
Are all instances of readout-dataflow to be bookkept, no matter the run type, config etc?
There was a problem hiding this comment.
I think so, that's what we do now via gRPC correct ? Or do you see a case where we don't do the gRPC call ?
There was a problem hiding this comment.
@vascobarroso whether the gRPC calls are triggered currently depends on bookkeeping_enabled which is fully runtime.
There was a problem hiding this comment.
@teo yes but that's just an on/off switch. We can do the same thing for the new flag, but apart from that we always want to store.
|
Closing in favour of #664 |
No description provided.