Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWGHF: new task for W/Z->e in mid-rapidity #7582

Merged
merged 19 commits into from
Oct 3, 2024
Merged

PWGHF: new task for W/Z->e in mid-rapidity #7582

merged 19 commits into from
Oct 3, 2024

Conversation

sashingo
Copy link
Contributor

@sashingo sashingo commented Sep 5, 2024

PWGHF: a new task for W/Z decay to electron in midrapidity in Run3

@alibuild alibuild mentioned this pull request Sep 5, 2024
Closed
vkucera
vkucera requested changes Sep 5, 2024
View reviewed changes
PWGHF/HFL/Tasks/CMakeLists.txt Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/CMakeLists.txt Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
@sashingo sashingo closed this Sep 6, 2024
@sashingo sashingo reopened this Sep 6, 2024
@sashingo
Copy link
Contributor Author

sashingo commented Sep 6, 2024

Dear Vit,
thank you very much for reviewing the commit.

vkucera
vkucera reviewed Sep 6, 2024
View reviewed changes
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
vkucera
vkucera requested changes Sep 6, 2024
View reviewed changes
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
@sashingo
Copy link
Contributor Author

sashingo commented Sep 9, 2024

recommitted after implementing suggestions by Vit

@vkucera
Copy link
Collaborator

vkucera commented Sep 10, 2024

Thanks @sashingo for implementing the comments.
Please try to stick to the O2 naming conventions and use the lowerCamelCase style for the names of variables and functions. It improves readability of your code and helps others understand it.

vkucera
vkucera reviewed Sep 10, 2024
View reviewed changes
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
@sashingo
Copy link
Contributor Author

Hello, I think I address all the comments by Vit.
Please check and approve if it's ok.

NicoleBastid
NicoleBastid previously approved these changes Sep 25, 2024
View reviewed changes
@NicoleBastid NicoleBastid enabled auto-merge (squash) September 26, 2024 07:05
auto-merge was automatically disabled September 30, 2024 08:25

Head branch was pushed to by a user without write access

vkucera
vkucera requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sashingo , thanks for implementing the comments. Please seem some further suggestions.

PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx Outdated Show resolved Hide resolved
@sashingo
Copy link
Contributor Author

sashingo commented Oct 1, 2024

Hi Vit,
thank you for further suggestions.
I implemented them

vkucera
vkucera approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sashingo for implementing all my comments.

@vkucera vkucera merged commit c8ab91c into AliceO2Group:master Oct 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkucera vkucera vkucera approved these changes

@NicoleBastid NicoleBastid NicoleBastid left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sashingo @vkucera @NicoleBastid