feat: otter training sdk - small fixes #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9971769. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
fpaul-1A
reviewed
Dec 5, 2024
| @@ -21,7 +21,7 @@ export class AppComponent { | |||
| } | |||
|
|
|||
| public async setPets() { | |||
| /* Get the first 10 pets whose status is 'available' */ | |||
| // TODO Get the first 10 pets whose status is 'available' | |||
There was a problem hiding this comment.
not sure the TODO is relevant here, the task is already done
sdo-1A
force-pushed
the
feat/training-sdk-fixes
branch
from
c0abfbd to
2766b9c
Compare
sdo-1A
force-pushed
the
feat/training-sdk-fixes
branch
from
2766b9c to
9971769
Compare
fpaul-1A
approved these changes
Dec 5, 2024
kpanot
approved these changes
Dec 5, 2024
kpanot
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Small fixes before big PR into main
Update "TODO" comments in the exercise files to have regularity between the steps
Related issues
- No issue associated -