Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: otter training sdk - small fixes #2554

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/showcase/src/assets/trainings/sdk/program.json
Original file line number Diff line number Diff line change
Expand Up @@ -129,27 +129,27 @@
"htmlContentUrl": "./steps/date/instructions.md",
"filesConfiguration": {
"name": "utils-date",
"startingFile": "apps/app/src/app/app.component.ts",
"startingFile": "apps/tutorial-app/src/app/app.component.ts",
"urls": [
{
"path": ".",
"contentUrl": "./shared/monorepo-template.json"
},
{
"path": "./apps/app/src/app",
"path": "./apps/tutorial-app/src/app",
"contentUrl": "./steps/date/exercise.json"
}
],
"solutionUrls": [
{
"path": "./apps/app/src/app",
"path": "./apps/tutorial-app/src/app",
"contentUrl": "./steps/date/solution.json"
}
],
"mode": "interactive",
"commands": [
"npm install --legacy-peer-deps --ignore-scripts --no-audit --prefer-dedupe",
"npm run ng run app:serve"
"npm run ng run tutorial-app:serve"
]
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ paths:
components:
schemas:
Flight:
# Complete these specifications with the provided instructions
# TODO Complete these specifications with the provided instructions
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class AppComponent {
/** Title of the application */
public title = 'tutorial-app';

/** Date value used to initialize the two date variables */
/** Date value used to initialize the variables date and dateTime */
public dateValue = '';
/** Date variable of type Date */
public date: Date | null = null;
Expand All @@ -24,6 +24,6 @@ export class AppComponent {
}

public updateValues() {
/* Set the values of the two variables here */
// TODO Set the values of the variables date and dateTime here
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class AppComponent {
/** Title of the application */
public title = 'tutorial-app';

/** Date value used to initialize the two date variables */
/** Date value used to initialize the variables date and dateTime */
public dateValue = '2024-09-01T10:00:00+02:00';
/** Date variable of type Date */
public date: Date | null = null;
Expand All @@ -24,7 +24,6 @@ export class AppComponent {
}

public updateValues() {
/* Set the values of the two variables here */
this.date = new Date(this.dateValue);
this.dateTime = new utils.DateTime(this.dateValue);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/* TODO Export your extended model and reviver instead of the original ones */
// TODO Export your extended model and reviver instead of the original ones
export type { Flight } from './flight';
export { reviveFlight } from './flight.reviver';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* TODO Modify the implementation of reviveFlightFactory to call `baseRevive` and add an extra id */
// TODO Modify the implementation of reviveFlightFactory to call `baseRevive` and add an extra id
import type { reviveFlight } from '../../base/flight/flight.reviver';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* TODO create the type FlightCoreIfy which extends Flight, imported from the ../base folder */
/* Add an extra field `id: string` */
// TODO Create the type FlightCoreIfy which extends Flight, imported from the ../base folder
// TODO Add an extra field `id: string`

/**
* Extended type for Flight
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export class AppComponent {
}

public async setPets() {
/* Get the first 10 pets whose status is 'available' */
const availablePets = await this.petStoreApi.findPetsByStatus({status: 'available'});
this.petsWritable.set(availablePets.slice(0, 10));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ export class AppComponent {
}

public async setPets() {
/* Get the first 10 pets whose status is 'available' */
// TODO Get the first 10 pets whose status is 'available'
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { routes } from './app.routes';


function petApiFactory() {
/* Create an ApiFetchClient and return a PetApi object */
// TODO Create an ApiFetchClient and return a PetApi object
}

export const appConfig: ApplicationConfig = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export class AppComponent {
}

public async setPets() {
/* Get the first 10 pets whose status is 'available' */
const availablePets = await this.petStoreApi.findPetsByStatus({status: 'available'});
this.petsWritable.set(availablePets.slice(0, 10));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { routes } from './app.routes';


function petApiFactory() {
/* Create an ApiFetchClient and return a PetApi object */
const apiFetchClient = new ApiFetchClient(
{
basePath: 'https://petstore3.swagger.io/api/v3',
Expand Down
Loading