Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Multisig Transactions & Application Proposals: Adds metadata to entities #13

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

SovereignAndrey
Copy link
Contributor

Ticket(s):
Request for metadata to be included in subgraph

Related to: AngelProtocolFinance/evm-smart-contracts#228

Explanation of the solution

  • Adds metadata bytes to the entities: ApplicationProposal & MultiSigTransaction
  • Standardizes Metadata as bytes for input type Charity Applications (previously used string)
  • Updates mappings to save passed metadata bytes to the entities

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

Copy link
Contributor

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to redeploy the changed contracts first and then update their respective addresses (and optionally start blocks) here in subgraph.yaml in order for Subgraph to track those events correctly.

Other than that, all seems good 👍

@0xNeshi 0xNeshi merged commit 638ae4b into main Jul 25, 2023
@0xNeshi 0xNeshi deleted the metadata-added branch July 25, 2023 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants