Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Multisig TXs & Application Proposals: Metadata added to event emits #228

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

SovereignAndrey
Copy link
Contributor

@SovereignAndrey SovereignAndrey commented Jul 25, 2023

Ticket(s):
Request for metadata to be included in subgraph, leads us to need to add it to the event emissions for:

  1. Generic MultiSig Transaction Submission (covers AP Team & Charity Applications multisigs)
  2. Normalized Endowment MultiSig Transaction Submission
  3. Charity Applications Proposal Submission

Related to: AngelProtocolFinance/ap-subgraph#13

Explanation of the solution

  • Adds metadata to the various event emits
  • Standardizes Metadata as bytes for input type for functions & in storage field type used (previously Charity Applications used string & Normalized Endowments used bytes)

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

@SovereignAndrey SovereignAndrey merged commit 91e3396 into master Jul 25, 2023
1 check failed
@SovereignAndrey SovereignAndrey deleted the meta-emit branch July 25, 2023 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants