Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

refactor: add tab navigation to single tile component #660

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alfonsobries
Copy link
Contributor

Summary

https://app.clickup.com/t/1hwy93h

To test:

  1. merge this on msq
  2. recompile assets
  3. you should be able to navigate to the category tiles with the keyboard
  4. press space to select an option
  5. in case you wonder, the enter key doesn't do anything, and you cannot deselect by pressing space two times (same behavior that a native checkbox have)

image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I provided a screenshot of my changes to the component (if applicable)
  • I regenerated the icons.html file and checked if my newly added icon is shown correctly (if necessary)
  • I added an explanation on how to use the component to the readme (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alfonsobries alfonsobries changed the title refactor: add tab capabilities to the single tile component refactor: add tab navigation to single tile component Sep 22, 2021
@leMaur leMaur self-assigned this Sep 27, 2021
Copy link
Contributor

@leMaur leMaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants