Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_mount if /etc/resolv.conf is symlink #86

Closed
wants to merge 1 commit into from

Conversation

IsaacMarovitz
Copy link

Should resolve #85 (same issue occurs on my system).

@slp
Copy link
Collaborator

slp commented Oct 15, 2024

In my system, /etc/resolv.conf is a symlink but I don't have an issue here without this PR. How does the issue manifest in your system?

@teohhanhui
Copy link
Collaborator

teohhanhui commented Oct 15, 2024

Looking at the docs: https://github.com/sunfishcode/linux-mount-api-documentation/blob/main/move_mount.md

I don't understand why it matters whether /etc/resolv.conf is a symlink or not. The move_mount call is moving the mount from /tmp/resolv.conf to /etc/resolv.conf, right? What does it mean to follow the destination symlink?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't launch, crashes.
3 participants