-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pt_br.json #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using "Mapa de Exploração" instead of "Mapa do Explorador" since we are in Java Edition, the "Mapa do Explorador" would be for the Bedrock Edition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small review from my perspective as a Portuguese Native speaker, open to discussion
Other than that, the other translations seem good enough
"filled_map.dungeons_arise:monastery": "Mapa do Explorador do Mosteiro", | ||
"filled_map.dungeons_arise:illager_campsite": "Mapa do Explorador do Acampamento Illager", | ||
"filled_map.dungeons_arise:illager_castle": "Mapa do Explorador do Castelo Illager", | ||
"filled_map.dungeons_arise:illager_hall": "Mapa do Explorador do Illager Hall", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hall" can be translated as "Salão" or "Corredor", I believe "Salão" would fit better
@@ -0,0 +1,32 @@ | |||
{ | |||
"filled_map.dungeons_arise:monastery": "Mapa do Explorador do Mosteiro", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe "monastery" would be better translated as "Monastério" instead, open to discussion
"filled_map.dungeons_arise:abandoned_temple": "Mapa do Explorador do Templo Abandonado", | ||
"filled_map.dungeons_arise:lighthouse": "Mapa do Explorador do Farol", | ||
"filled_map.dungeons_arise:mushroom_mines": "Mapa do Explorador de Minas de Cogumelo", | ||
"filled_map.dungeons_arise:mushroom_village": "Mapa do Explorador da Aldeia do Cogumelo", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"de" instead of "do" would fit better since you used the same for the line above
"filled_map.dungeons_arise:mushroom_village": "Mapa do Explorador da Aldeia do Cogumelo", | ||
"filled_map.dungeons_arise:coliseum": "Mapa do Explorador do Coliseu", | ||
"filled_map.dungeons_arise:fishing_hut": "Mapa do Explorador da Cabana de Pesca", | ||
"filled_map.dungeons_arise:small_prairie_house": "Mapa do Explorador da Pequena Pradaria", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Pequena Casa de Pradaria" would be the correct translation, since it's a map for the house in the prairie, and not the prairie itself
"filled_map.dungeons_arise:heavenly_rider": "Mapa do Explorador do Cavaleiro Celestial", | ||
"filled_map.dungeons_arise:mining_system": "Mapa do Explorador do Sistema de Mineração", | ||
"filled_map.dungeons_arise:heavenly_conqueror": "Mapa do Explorador do Conquistador Celestial", | ||
"filled_map.dungeons_arise:scorched_mines": "Mapa das Minas Queimadas", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to discuss the best translation for "scorched" as "queimadas" don't really seem accurate with the structure, does anyone have some ideas?
"filled_map.dungeons_arise:small_blimp": "Mapa do Explorador do Dirigível Pequeno", | ||
"filled_map.dungeons_arise:bandit_village": "Mapa do Explorador da Vila dos Bandidos", | ||
"filled_map.dungeons_arise:typhon": "Mapa do Explorador do Typhon", | ||
"filled_map.dungeons_arise:ceryneian_hind": "Mapa do Explorador Ceryneian Hind", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if "Ceryneian Hind" does reassemble the deer from Greek mythology, it could be translated as "Corça de Cerineia"
"filled_map.dungeons_arise:typhon": "Mapa do Explorador do Typhon", | ||
"filled_map.dungeons_arise:ceryneian_hind": "Mapa do Explorador Ceryneian Hind", | ||
"filled_map.dungeons_arise:heavenly_challenger": "Mapa do Explorador do Desafiante Celestial", | ||
"filled_map.dungeons_arise:illager_corsair": "Mapa do Explorador Illager Corsair", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Corsair" in this context is the ship so it could be translated as "Corsário"
(historically, ships that engages in maritime warfare under a commission of war.)
"filled_map.dungeons_arise:ceryneian_hind": "Mapa do Explorador Ceryneian Hind", | ||
"filled_map.dungeons_arise:heavenly_challenger": "Mapa do Explorador do Desafiante Celestial", | ||
"filled_map.dungeons_arise:illager_corsair": "Mapa do Explorador Illager Corsair", | ||
"filled_map.dungeons_arise:illager_galley": "Mapa do Explorador da Galera Illager", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to discuss this one, as "Galé" could also be the translation to "Galley", since "Galera" would look like we talking about the "Illager people" (as "galera" is an expression to a group of people in portuguese)
"filled_map.dungeons_arise:heavenly_challenger": "Mapa do Explorador do Desafiante Celestial", | ||
"filled_map.dungeons_arise:illager_corsair": "Mapa do Explorador Illager Corsair", | ||
"filled_map.dungeons_arise:illager_galley": "Mapa do Explorador da Galera Illager", | ||
"filled_map.dungeons_arise:mushroom_house": "Mapa do Explorador da Casa do Cogumelo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, same as the other one, would be nice to keep a pattern of using "de Cogumelo" instead of "do Cogumelo"
"filled_map.dungeons_arise:scorched_mines": "Mapa das Minas Queimadas", | ||
"filled_map.dungeons_arise:undead_pirate_ship": "Mapa do Explorador do Navio Pirata Morto-Vivo", | ||
"filled_map.dungeons_arise:foundry": "Mapa do Explorador de Fundição", | ||
"filled_map.dungeons_arise:small_blimp": "Mapa do Explorador do Dirigível Pequeno", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Pequeno Dirigível" instead, but I'm open to discussion
Okay, I'll make the changes. |
No description provided.