Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: external navigation interface #8

Merged
merged 4 commits into from
Jan 8, 2024
Merged

tests: external navigation interface #8

merged 4 commits into from
Jan 8, 2024

Conversation

GuillaumeLaine
Copy link
Member

@GuillaumeLaine GuillaumeLaine commented Dec 5, 2023 •
edited by jira bot
Loading

Navigation interface

Unit Tests:

  • Publish invalid measurements and check exceptions are thrown correctly.

Test with ./build/px4_ros2_cpp/px4_ros2_cpp_unit_tests --gtest_filter='*Interface*'

Integration Tests:

  • Publish measurement via interface and check that PX4 confirms measurement fusion via estimator status flags.

Interface/Example Tweaks

  • Log error message only once to avoid spamming the user when they catch interface exception.
  • Add exception handling to examples

Control mode interface

  • Rename mode integration tests Tester -> ModesTest

Jira: APX4-3591

bkueng
bkueng reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and cleanup the commits?

px4_ros2_cpp/test/integration/global_navigation.cpp Outdated Show resolved Hide resolved
px4_ros2_cpp/test/unit/global_navigation.cpp Outdated Show resolved Hide resolved
@GuillaumeLaine GuillaumeLaine force-pushed the test_navigation_interface branch from 1c90b38 to 3f06567 Compare December 7, 2023 12:59
@GuillaumeLaine GuillaumeLaine changed the title test: external navigation interface tests: external navigation interface Dec 7, 2023
@GuillaumeLaine GuillaumeLaine force-pushed the test_navigation_interface branch 2 times, most recently from 3347b23 to 569c5ca Compare December 13, 2023 13:21
@GuillaumeLaine GuillaumeLaine force-pushed the test_navigation_interface branch from 569c5ca to e2db92a Compare December 13, 2023 13:33
bkueng added a commit to PX4/PX4-Autopilot that referenced this pull request Dec 14, 2023
@bkueng
ros_tests: change filter to use all tests
e9927fc 
The name is being changed in Auterion/px4-ros2-interface-lib#8
bkueng
bkueng reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you squash the last commit into the relevant previous one?

@GuillaumeLaine GuillaumeLaine force-pushed the test_navigation_interface branch from cbeab2c to 6e5e22b Compare December 18, 2023 08:39
@bkueng bkueng merged commit 9dbb37a into main Jan 8, 2024
10 checks passed
@bkueng bkueng deleted the test_navigation_interface branch January 8, 2024 10:21
bkueng added a commit to PX4/PX4-Autopilot that referenced this pull request Jan 19, 2024
@bkueng
ros_tests: change filter to use all tests
79834fd 
The name is being changed in Auterion/px4-ros2-interface-lib#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeLaine @bkueng