EMSUSD-65 use wait cursor for payload commands #3513
Conversation
pierrebai-adsk
commented
Dec 12, 2023
pierrebai-adsk
commented
- Add a USD UFE long-duration command to wrap other commands that may take a long time to run.
- Add two DCC-specific functions to start and stop the wait cursor.
- Add start/stop helper functions.
- Add a wait cursor class to automatically start and top the wait cursor.
- Wrap the load and unload payload commands in a long-duration command.
- Adjust existing commands that used a wait cursor to use the global helper class instead.
pierrebai-adsk
added
adsk
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-65/load-payload-wait-cursor
branch
from
5e5ebd4 to
7ec51b6
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-65/load-payload-wait-cursor
branch
from
7ec51b6 to
4fcef83
Compare
- Add a USD UFE long-duration command to wrap other commands that may take a long time to run. - Add two DCC-specific functions to start and stop the wait cursor. - Add start/stop helper functions. - Add a wait cursor class to automatically start and top the wait cursor. - Wrap the load and unload payload commands in a long-duration command. - Adjust existing commands that used a wait cursor to use the global helper class instead.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-65/load-payload-wait-cursor
branch
from
4fcef83 to
8f8210a
Compare
| @@ -107,6 +108,10 @@ MCallbackId gExitingCbId = 0; | |||
| // Subject singleton for observation of all USD stages. | |||
| MayaUsd::ufe::MayaStagesSubject::RefPtr g_StagesSubject; | |||
|
|
|||
| void mayaStartWaitCursor() { MGlobal::executeCommand("waitCursor -state 1"); } | |||
There was a problem hiding this comment.
This seems like something that should be in usdUfe/Utils and not Global, as this isn't manipulating or using anything Ufe and I think it is going to be useful for the rest of MayaUsd.
There was a problem hiding this comment.
Other code can use the usdUfe API, not this implementation. Particularly since the code in usdUfe manages the recursivity count and provide a utility WaitCursor class.
There was a problem hiding this comment.
mayaUsd has access to usdUfe but probably not the other way around.
I also noticed that you've removed the struct in MayaUsdContextOps.
There was a problem hiding this comment.
This particular code cannot be in UsdUfe since it uses Maya. UsdUfe does not (and cannot) depend on Maya. The way that Pierre wrapped it behind dccFunctions is the correct thing to do.
pierrebai-adsk
changed the title
|
Only PF failure is a singel test on a single platform due to a USDC file remaining in the tmp folder. |
pierrebai-adsk
added
the
ready-for-merge
