Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App doesn't handle direct episode links with timestamps #2405

Open
1 task done
MiSikora opened this issue Jun 27, 2024 · 0 comments · May be fixed by #2447
Open
1 task done

App doesn't handle direct episode links with timestamps #2405

MiSikora opened this issue Jun 27, 2024 · 0 comments · May be fixed by #2447
Assignees
@MiSikora
Labels
bug Something isn't working Reimagine Sharing

Comments

@MiSikora
Copy link
Contributor

Description

Sharing something like https://pca.st/episode/c510a66f-f9c0-45c8-bca2-8c0cc1d5f055?t=1327 with the app doesn't recognize the 1327 timestamp. It is because the link is treated as a regular episode link due to 2 path segments here:

pocket-casts-android/app/src/main/java/au/com/shiftyjelly/pocketcasts/ui/MainActivity.kt

Lines 1548 to 1564 in 9cf0a90

private fun openNativeSharingUrl(intent: Intent) {
val urlSegments = intent.data?.pathSegments ?: return
if (urlSegments.size < 2) {
openSharingUrl(intent)
return
}
when (urlSegments[0]) {
"podcast" -> openPodcastUrl(IntentUtil.getUrl(intent))
"episode" -> openEpisodeDialog(
episodeUuid = urlSegments[1],
source = EpisodeViewSource.SHARE,
podcastUuid = null,
forceDark = false,
)
}
}

The reason why something like https://pca.st/9mjo6ijv?t=1327 works is because it is not a direct and the /episode/ path is not there.

Step-by-step reproduction instructions

  1. Run adb shell am start -a android.intent.action.VIEW -d https://pca.st/episode/c510a66f-f9c0-45c8-bca2-8c0cc1d5f055\?t=1327
  2. Notice that episode details show but the playback from 1327 timestamp doesn't start.

Screenshots or screen recording

No response

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Google Pixel 6, Android 14, 9cf0a90
@MiSikora MiSikora added bug Something isn't working Reimagine Sharing labels Jun 27, 2024
@MiSikora MiSikora mentioned this issue Jun 27, 2024
Merged
10 tasks
@MiSikora MiSikora changed the title App doesn't handle direct episode link with timestamps App doesn't handle direct episode links with timestamps Jun 27, 2024
@MiSikora MiSikora self-assigned this Jul 4, 2024
This was referenced Jul 4, 2024
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiSikora MiSikora

Labels
bug Something isn't working Reimagine Sharing
Projects
None yet
Milestone
No milestone
1 participant
@MiSikora