Expand interface-driven datasource configs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdef
changed the title
mhsdef
changed the title
chriszarate
reviewed
Sep 12, 2024
chriszarate
reviewed
Sep 12, 2024
chriszarate
reviewed
Sep 12, 2024
chriszarate
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It is not a silver bullet, but, programming to interfaces and favoring composition over inheritance can provide tighter abstractions, looser couplings, and useful flexibility.
See this (contrived) example of what that can mean in practice:
Inheritance embraced
vs
Composition, Interfaces
The wins there may look small but when multiplied over real world scenarios hundreds or thousands of times--I promise, they add up. The mental overhead wins and testability wins make it worth it in my experience.
How
We already had a
HttpDatasourceConfiginterface in the codebase. This PR attempts to shift some more core parts that direction, elevate a compositional approach, and lays some groundwork for additional explicit contracts (ie, interfaces, mostly, in PHP).