Set orderby to none for order queries where checking if order exists.
#10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
6 tasks
vladolaru
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Great enhancement, @prettyboymp! The code changes LGTM and testing checks out. 
|
@prettyboymp I went ahead and merged this PR so I can include the changes in the caching PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #10046 (caching should still be added)
Changes proposed in this Pull Request
Set orderby to
nonefor order queries where checking if order exists.The queries run by
wc_get_orders()as requested fromWC_Payments_Incentives_Service->get_store_context()are pretty slow for sites with a large number or orders. Since we only need to check if an order exists, we can optimize these queries a bit by setting theorderbyclause tonone. This allows the query to return as soon as it finds the first matching record rather than needing to continue to scan for all the matching rows so it can sort to find the newest order.This only improves the query performance if an order matching the criteria exists, but it is at least a start. We should add caching around these queries to avoid the need to have them run every admin page load.
Testing instructions