Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase padding on email login link for it locale #96382

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Increase padding on email login link for it locale #96382

wants to merge 2 commits into from

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Nov 14, 2024

Fixes #96280

Proposed Changes

  • Increases padding around login link text

Testing Instructions

Before

After

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124632
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124632&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-124632&env=a8c-for-agencies

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2024
lsl
lsl commented Nov 14, 2024
View reviewed changes
client/blocks/login/social.scss
@@ -67,7 +67,7 @@
max-width: 240px;
text-align: center;
margin-right: auto;
margin-left: -20px;
margin-left: -10px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this entirely looks better on desktop but it looks off center with the separator on mobile.

lsl
lsl commented Nov 14, 2024
View reviewed changes
client/blocks/login/social.scss
@@ -42,7 +42,7 @@
border: 1px solid var(--studio-gray-50, #646970);
border-radius: 4px;
display: flex;
height: 40px;
height: 44px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50px looks a lot better but I opted for 44 to match the height of the continue button on the left. This also prevents the forgot password link falling below the fold on some smaller mobile screens.

@lsl lsl self-assigned this Nov 14, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Nov 14, 2024 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/login-email-button on your sandbox.

taipeicoder
taipeicoder approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 we can also add text-wrap: balance to avoid widows.

Screenshot 2024-11-14 at 11 12 30 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taipeicoder taipeicoder taipeicoder approved these changes

@escapemanuele escapemanuele Awaiting requested review from escapemanuele

Assignees

@lsl lsl

Labels
Lego Maintenance [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login: Email link button text can have more space
3 participants
@lsl @matticbot @taipeicoder