Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase padding on email login link for it locale #96382

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/blocks/login/social.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@
border: 1px solid var(--studio-gray-50, #646970);
border-radius: 4px;
display: flex;
height: 40px;
height: 44px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

50px looks a lot better but I opted for 44 to match the height of the continue button on the left. This also prevents the forgot password link falling below the fold on some smaller mobile screens.

justify-content: center;
margin-bottom: 0;
padding: 4px 16px;
border-color: #ccc;
text-wrap: balance;

& > svg.social-icons {
border: 0;
Expand All @@ -67,7 +68,7 @@
max-width: 240px;
text-align: center;
margin-right: auto;
margin-left: -20px;
margin-left: -10px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this entirely looks better on desktop but it looks off center with the separator on mobile.

}
}
}
Expand Down
Loading