feat: refactor cni telemetry

[QxBytes]

Reason for Change:

Currently the telemetry CNI is sending is insufficient to debug CNI issues. This PR refactors the cni telemetry to send more and better quality logs.

• Moves telemetry into a package level variable so it is made accessible everywhere
• Removes sending certain metrics as they are not used
• Sets the subcontext to the container id. The container id is kept consistent throughout CNI calls for the same pod, meaning an ADD and DEL call (and all related logs) for the same pod will have the same subcontext/container id. The container id is also what is stored in stateless mode as one of the keys.
• Sets the operation id before any telemetry events are sent. The operation id is used for sampling should we end up enabling it.

Examples of Logged information (Will be added in a separate PR-- this PR is focused on refactoring)

• CNI add network configuration, arguments
• CNI add completion with endpoint info struct information (contains hns endpoint id and hns network id), interface results from the ipam invoker, and any error that occurred
• CNI del network configuration, arguments
• CNI del completion with error that occurred
• HNS Endpoint struct before creation / HNS Endpoint Id during deletion
• HNS Network struct before creation / HNS Network Id during deletion
• Deletion/Release of each IP (even if does not exist)
• Mapping sent to CNS during stateless CNI mode during Update Endpoint State
• Exact CNS response from CNS ipam invoker
• Exact CNS response from multitenancy ipam invoker
• Transparent vlan creating/deleting vlan veth interface

Potential additions:

• endpoint and network structs saved to azure-vnet.json statefile

Issue Fixed:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• relevant PR labels added

Notes:
Pipeline run to prove logs sent to kusto: https://msazure.visualstudio.com/One/_build/results?buildId=108208651&view=results
Passing run: https://msazure.visualstudio.com/One/_build/results?buildId=108563465&view=results

[QxBytes]

/azp run Azure Container Networking PR

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[timraymond]

LGTM on @ramiro-gamarra 's approval

[ramiro-gamarra]

I may still be missing some details about the purpose of this refactor, but seems to me that logs are getting duplicated and the abstractions introduced are not cleaning up the code much yet.

[behzad-mir]

lgtm

[QxBytes]

/azp run Azure Container Networking PR

[Copilot]

Pull Request Overview

This PR refactors the telemetry logging functionality across the Azure Container Networking codebase, improving consistency and simplifying telemetry integration by using a package-level telemetry client. Key changes include migrating telemetry state to a global variable (AIClient), updating telemetry error/event logging calls, and removing obsolete metrics and report fields.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

File	Description
telemetry/telemetrybuffer.go	Changed logging level from error to warn when failing to kill the telemetry process
telemetry/telemetry_client.go & telemetry.go	Introduced and utilized the package-level telemetry client (AIClient)
network/* and cni/network/*	Updated telemetry calls and removed unused telemetry fields; added generic helpers
Various test files	Removed references to TelemetryBuffer and CNIReport from tests in favor of AIClient

Comments suppressed due to low confidence (3)

telemetry/telemetrybuffer.go:311

• The log level for a failed process kill was changed from error to warn. Confirm that downgrading the severity here is intentional and does not obscure critical errors in production.

tb.logger.Warn("Failed to kill process by", zap.String("TelemetryServiceProcessName", TelemetryServiceProcessName), zap.Error(err))

network/endpoint.go:158

• Ensure that the 'strings' package is imported in this file since the function uses strings.Builder, otherwise this will result in a compilation error.

func FormatSliceOfPointersToString[T any](slice []*T) string {

cni/network/network.go:297

• The package-level telemetry client (telemetryClient) is being modified directly without synchronization. Consider adding concurrency controls or ensuring that these updates are performed safely if accessed from multiple goroutines.

func (plugin *NetPlugin) setCNIReportDetails(containerID, opType, msg string) {

[github-actions]

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

[vipul-21]

The changes lgtm to me apart from couple of comments.
@tamilmani1989 Can you please also take a look as well as.