Skip to content

feat: refactor cni telemetry #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat: refactor cni telemetry #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
d0dba47
move telemetry to dedicated package and create package variable
QxBytes Nov 7, 2024
faf37be
send telemetry for ipam config, epinfo, and error on cni add completion
QxBytes Nov 8, 2024
72c9708
add new telemetry logs for debugging
QxBytes Nov 11, 2024
8603a13
replace nwcfg subcontext with containerid for correlation
QxBytes Nov 11, 2024
445bf97
add mutex
QxBytes Nov 13, 2024
067a41c
address linter issues
QxBytes Nov 14, 2024
04b459d
add unit tests
QxBytes Nov 14, 2024
035a92a
set operation id before sending any events for sampling
QxBytes Nov 15, 2024
0664200
remove newly added telemetry events
QxBytes Nov 15, 2024
41baf1b
refactor plugin main
QxBytes Nov 18, 2024
45001d9
add unit tests and simplify
QxBytes Nov 18, 2024
fc02658
remove duplicate error telemetry
QxBytes Nov 19, 2024
980da29
fix comment
QxBytes Nov 19, 2024
3f7edef
remove writing telemetry events to the log file
QxBytes Nov 19, 2024
824418a
address feedback
QxBytes Nov 19, 2024
951f823
remove stutter
QxBytes Nov 19, 2024
0b4cf14
remove unused map (noop)
QxBytes Nov 21, 2024
472fc9b
address feedback
QxBytes Dec 5, 2024
343725f
fix condition
QxBytes Mar 7, 2025
68d7a0a
align flow with previous telemetry flow
QxBytes May 12, 2025
067c82d
address linter
QxBytes May 12, 2025
0d6bc61
re-implement add and delete timing metrics
QxBytes May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions cni/network/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,14 @@ import (
"encoding/json"
"io"
"os"
"reflect"

"github.com/Azure/azure-container-networking/cni"
"github.com/Azure/azure-container-networking/telemetry"
"github.com/containernetworking/cni/pkg/skel"
cniTypes "github.com/containernetworking/cni/pkg/types"
"github.com/pkg/errors"
"go.uber.org/zap"
)

// send error report to hostnetagent if CNI encounters any error.
func ReportPluginError(reportManager *telemetry.ReportManager, tb *telemetry.TelemetryBuffer, err error) {
logger.Error("Report plugin error")
reflect.ValueOf(reportManager.Report).Elem().FieldByName("ErrorMessage").SetString(err.Error())

if err := reportManager.SendReport(tb); err != nil {
logger.Error("SendReport failed", zap.Error(err))
}
}

func validateConfig(jsonBytes []byte) error {
var conf struct {
Name string `json:"name"`
Expand Down
Loading
Loading