-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove custom targets, use 'None' item group #1472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1472 +/- ##
===========================================
- Coverage 83.03% 45.88% -37.15%
===========================================
Files 36 35 -1
Lines 2322 2040 -282
Branches 346 302 -44
===========================================
- Hits 1928 936 -992
- Misses 295 1028 +733
+ Partials 99 76 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
This PR refactors the python worker nuget package targets as follows:
None
item group with appropriate metadata to haveCopyToOutputDirectory
andCopyToPublishDirectory
targets perform the copies for us.One of the main benefits is worker size when deployed for a specific runtime. On linux-x64, the workers/python folder goes from 533MB (all runtimes) to 87.8MB (linux-x64 only copied) (tested with python worker 4.34.0).
PR information
Quality of Code and Contribution Guidelines