Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove custom targets, use 'None' item group #1472

Merged
merged 13 commits into from
Dec 11, 2024
Merged

refactor: Remove custom targets, use 'None' item group #1472

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
708daff
Remove custom targets, use 'None' item group
jviau Apr 10, 2024
fd8b33b
Merge branch 'dev' into jviau/targets
jviau Apr 11, 2024
2f40dbd
Merge branch 'dev' into jviau/targets
YunchuWang Apr 12, 2024
33cadfa
Merge branch 'dev' into jviau/targets
YunchuWang Apr 12, 2024
ca0d27d
Merge remote-tracking branch 'origin/dev' into jviau/targets
jviau Apr 16, 2024
f49344c
Add runtime specific copy logic
jviau Apr 16, 2024
d3b1842
Add underscore to target name
jviau Apr 16, 2024
25ddb07
Merge branch 'dev' into jviau/targets
YunchuWang May 7, 2024
6586aaf
Merge branch 'dev' into jviau/targets
hallvictoria Jun 28, 2024
c33f1dd
Merge branch 'dev' into jviau/targets
jviau Nov 25, 2024
1c5e392
Merge branch 'dev' into jviau/targets
hallvictoria Dec 3, 2024
47eb886
Merge branch 'dev' into jviau/targets
hallvictoria Dec 4, 2024
80129e9
Merge branch 'dev' into jviau/targets
gavin-aguiar Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions pack/Microsoft.Azure.Functions.PythonWorker.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,43 @@
<Project>
<Target Name="Initialize" AfterTargets="Publish;Build">
<CreateItem Include="$(MSBuildThisFileDirectory)\..\">
<Output ItemName="MSBuildThisFileDirectoryParentDirectory" TaskParameter="Include"/>
</CreateItem>

<CreateProperty Value="%(MSBuildThisFileDirectoryParentDirectory.Fullpath)">
<Output PropertyName="NugetRoot" TaskParameter="Value"/>
</CreateProperty>
<PropertyGroup>
<_PythonWorkerToolsDir>$([System.IO.Path]::GetFullPath('$(MSBuildThisFileDirectory)../tools'))</_PythonWorkerToolsDir>
</PropertyGroup>

<ItemGroup Condition="'$(RuntimeIdentifier)' != ''">
<_PythonSupportedRuntime Include="win-x86" WorkerPath="WINDOWS/X86" />
<_PythonSupportedRuntime Include="win-x64" WorkerPath="WINDOWS/X64" />
<_PythonSupportedRuntime Include="linux-x64" WorkerPath="LINUX/X64" />
<_PythonSupportedRuntime Include="osx-x64" WorkerPath="OSX/X64" />
<_PythonSupportedRuntime Include="osx-arm64" WorkerPath="OSX/Arm64" />
</ItemGroup>

<Target Name="_GetFunctionsPythonWorkerFiles" BeforeTargets="AssignTargetPaths" DependsOnTargets="_GetFunctionsPythonWorkerFilesNoRuntime;_GetFunctionsPythonWorkerFilesForRuntime">
<ItemGroup>
<SourceFiles Include="$(NugetRoot)tools\**\*.*"/>
<None Include="@(_PythonWorkerFiles)" TargetPath="workers/python/%(RecursiveDir)%(Filename)%(Extension)" />
</ItemGroup>
</Target>

<Target Name="CopyOnPublish" DependsOnTargets="Initialize" AfterTargets="Publish">
<Copy SourceFiles="@(SourceFiles)"
DestinationFiles="@(SourceFiles->'$(PublishDir)\workers\python\%(RecursiveDir)%(Filename)%(Extension)')" />
<!-- When no runtime is specified, copy all runtimes. -->
<Target Name="_GetFunctionsPythonWorkerFilesNoRuntime" Condition="'$(RuntimeIdentifier)' == ''">
<ItemGroup>
<_PythonWorkerFiles Include="$(_PythonWorkerToolsDir)/**" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="PreserveNewest" />
</ItemGroup>
</Target>

<Target Name="CopyOnBuild" DependsOnTargets="Initialize" AfterTargets="Build">
<Copy SourceFiles="@(SourceFiles)"
DestinationFiles="@(SourceFiles->'$(OutDir)\workers\python\%(RecursiveDir)%(Filename)%(Extension)')" />
<!-- When a runtime is specified, copy only that runtimes files. -->
<Target Name="_GetFunctionsPythonWorkerFilesForRuntime" Condition="'$(RuntimeIdentifier)' != ''">
<PropertyGroup>
<_PythonWorkersRuntimeFolder>@(_PythonSupportedRuntime->WithMetadataValue('Identity', '$(RuntimeIdentifier)')->Metadata('WorkerPath'))</_PythonWorkersRuntimeFolder>
</PropertyGroup>

<ItemGroup>
<_PythonWorkerFiles Include="$(_PythonWorkerToolsDir)/*" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="PreserveNewest" />
<_PythonWorkerFiles Include="$(_PythonWorkerToolsDir)/**/$(_PythonWorkersRuntimeFolder)/**" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="PreserveNewest" />
</ItemGroup>

<!-- Error out if runtime is not supported. -->
<Error Condition="'$(_PythonWorkersRuntimeFolder)' == ''" Text="Runtime '$(RuntimeIdentifier)' is not supported by the Python worker. Supported runtimes are @(_PythonSupportedRuntime)." />
</Target>

</Project>
Loading