Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Responses support #44616

Merged
merged 60 commits into from
Mar 14, 2025
Merged

OpenAI Responses support #44616

merged 60 commits into from
Mar 14, 2025

Conversation

jpalvarezl
Copy link
Member

@jpalvarezl jpalvarezl commented Mar 12, 2025 •
edited
Loading

Adding Responses API support for the AOAI SDK in the inference package under com.azure.ai.openai.reponses.

This relates to: https://platform.openai.com/docs/guides/responses-vs-chat-completions

@jpalvarezl
Added responses as a subpackage
a37f90d
@jpalvarezl
Added test and sample
dad5eec
@jpalvarezl
Streaming works
251c3b3
@jpalvarezl
not sure why this file gets constantly modified
bfee8df
@jpalvarezl
Added tests for SSE implementation
46ffa70
@jpalvarezl
Added more convenience methods
3c8846d
@jpalvarezl
Added more convenience methods
4b250a8
@jpalvarezl
Adding customization for service version add when necessary
2763b11
@jpalvarezl
Fixed wrongfully named variant
2fa86ee
@jpalvarezl
Added sync test file for non-Azure OpenAI
7bdf9e2
@jpalvarezl
WIP: adding support for non-Azure OpenAI
f3b6f33
@jpalvarezl
Code gen responses latest
8e4c52e
@jpalvarezl
Codegen for inference, still ok
64f2b03
@jpalvarezl
Merge branch 'main' into jpalvarezl/responses
50d1572
@jpalvarezl
fixed client impl and sample returns 200
903945f
@jpalvarezl
Added azure/non-azure mode
10e8d16
@jpalvarezl
Compiling again with latest TSP definitions
215643c
@jpalvarezl
Up to date with PR with feedback
a852497
@jpalvarezl
Cleanup
9cd5a35
@jpalvarezl
Models updated
427bf6b
@jpalvarezl
Added custom constructor for request object and adjusted tests and sa…
9f3475a 
…mples
@jpalvarezl
Some class renaming
ed9dcf3
@jpalvarezl
Added unit tests for OAI and added spell check ex
9ef48f3
@jpalvarezl
Added missing async convenience methods and added full test coverage …
a1ab4d9 
…nonAzure sync
@jpalvarezl
Added async tests
5e9ae00
@jpalvarezl
style and bug checks passing
f45686c
@jpalvarezl
Test cleanup and re-enabled azure
4692477
@jpalvarezl
Refreshed spec
daed899
@jpalvarezl
PR feedback
50b96f2
@jpalvarezl
Style checks
dd2802d
@jpalvarezl jpalvarezl changed the title WIP: OpenAI Responses support OpenAI Responses support Mar 13, 2025
@jpalvarezl jpalvarezl marked this pull request as ready for review March 13, 2025 20:44
@jpalvarezl
Copy link
Member Author

Thanks for the feedback! So just to be completely aligned on the follow-up: what we generally want to expose is a couple of methods that return Response<T> and T where T is not BinaryData but a deserialized type? Since this is an additive change, more than happy to follow-up on this immediately after the release.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-openai

@jpalvarezl jpalvarezl enabled auto-merge (squash) March 14, 2025 13:06
mssfang
mssfang approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@mssfang mssfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. We can add those withResponse methods without using BinaryData after this version.

@jpalvarezl jpalvarezl merged commit 9a8bfe3 into main Mar 14, 2025
41 checks passed
@jpalvarezl jpalvarezl deleted the jpalvarezl/responses branch March 14, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mssfang mssfang mssfang approved these changes

@srnagar srnagar srnagar approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@brandom-msft brandom-msft Awaiting requested review from brandom-msft brandom-msft is a code owner

Assignees
No one assigned
Labels
common common module used by all azure SDKs (e.g. client, Mgmt) OpenAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpalvarezl @azure-sdk @mssfang @srnagar