PR feedback

sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/implementation/OpenAIUtils.java

@@ -46,8 +46,4 @@ public static void addAzureVersionToRequestOptions(String endpoint, RequestOptio
     public static boolean useAzureOpenAIService(String endpoint) {
         return endpoint != null && !endpoint.startsWith(OPEN_AI_ENDPOINT);
     }
-
-    public static String getOpenAIEndpoint() {
-        return OPEN_AI_ENDPOINT;
-    }
 }

sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/responses/ResponsesAsyncClient.java

@@ -202,8 +202,8 @@ public final class ResponsesAsyncClient {
     @ServiceMethod(returns = ReturnType.SINGLE)
     public Mono<Response<BinaryData>> createResponseWithResponse(String accept, BinaryData requestBody,
         RequestOptions requestOptions) {
-        if (this.nonAzureServiceClient != null) {
-            return this.nonAzureServiceClient.createResponseWithResponseAsync(accept, requestBody, requestOptions);
+        if (nonAzureServiceClient != null) {
+            return nonAzureServiceClient.createResponseWithResponseAsync(accept, requestBody, requestOptions);
         } else {
             addAzureVersionToRequestOptions(serviceClient.getEndpoint(), requestOptions,
                 serviceClient.getServiceVersion());
@@ -299,8 +299,8 @@ public Mono<Response<BinaryData>> createResponseWithResponse(String accept, Bina
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
     public Mono<Response<BinaryData>> getResponseWithResponse(String responseId, RequestOptions requestOptions) {
-        if (this.nonAzureServiceClient != null) {
-            return this.nonAzureServiceClient.getResponseWithResponseAsync(responseId, requestOptions);
+        if (nonAzureServiceClient != null) {
+            return nonAzureServiceClient.getResponseWithResponseAsync(responseId, requestOptions);
         } else {
             addAzureVersionToRequestOptions(serviceClient.getEndpoint(), requestOptions,
                 serviceClient.getServiceVersion());
@@ -344,8 +344,8 @@ public Mono<Response<BinaryData>> getResponseWithResponse(String responseId, Req
     @ServiceMethod(returns = ReturnType.SINGLE)
     public Mono<Response<BinaryData>> listInputItemsWithResponse(String responseId, int limit, String order,
         String after, String before, RequestOptions requestOptions) {
-        if (this.nonAzureServiceClient != null) {
-            return this.nonAzureServiceClient.listInputItemsWithResponseAsync(responseId, limit, order, after, before,
+        if (nonAzureServiceClient != null) {
+            return nonAzureServiceClient.listInputItemsWithResponseAsync(responseId, limit, order, after, before,
                 requestOptions);
         } else {
             addAzureVersionToRequestOptions(serviceClient.getEndpoint(), requestOptions,
@@ -564,8 +564,8 @@ public Flux<ResponsesResponseStreamEvent> createResponseStream(CreateResponsesRe
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
     public Mono<Response<BinaryData>> deleteResponseWithResponse(String responseId, RequestOptions requestOptions) {
-        if (this.nonAzureServiceClient != null) {
-            return this.nonAzureServiceClient.deleteResponseWithResponseAsync(responseId, requestOptions);
+        if (nonAzureServiceClient != null) {
+            return nonAzureServiceClient.deleteResponseWithResponseAsync(responseId, requestOptions);
         } else {
             addAzureVersionToRequestOptions(serviceClient.getEndpoint(), requestOptions,
                 serviceClient.getServiceVersion());

sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/responses/ResponsesClient.java

@@ -14,6 +14,7 @@
 import com.azure.ai.openai.responses.models.DeleteResponseResponse;
 import com.azure.ai.openai.responses.models.ListInputItemsRequestOrder;
 import com.azure.ai.openai.responses.models.ResponsesInputItemList;
+import com.azure.ai.openai.responses.models.ResponsesItem;
 import com.azure.ai.openai.responses.models.ResponsesResponse;
 import com.azure.ai.openai.responses.models.ResponsesResponseStreamEvent;
 import com.azure.core.annotation.Generated;
@@ -24,6 +25,8 @@
 import com.azure.core.exception.HttpResponseException;
 import com.azure.core.exception.ResourceModifiedException;
 import com.azure.core.exception.ResourceNotFoundException;
+import com.azure.core.http.rest.PagedFlux;
+import com.azure.core.http.rest.PagedIterable;
 import com.azure.core.http.rest.RequestOptions;
 import com.azure.core.http.rest.Response;
 import com.azure.core.util.BinaryData;
@@ -277,7 +280,7 @@ public Response<BinaryData> getResponseWithResponse(String responseId, RequestOp
      * @return the response body along with {@link Response}.
      */
     @ServiceMethod(returns = ReturnType.SINGLE)
-    public Response<BinaryData> listInputItemsWithResponse(String responseId, int limit, String order, String after,
+    private Response<BinaryData> listInputItemsWithResponse(String responseId, int limit, String order, String after,
         String before, RequestOptions requestOptions) {
         if (nonAzureServiceClient != null) {
             return nonAzureServiceClient.listInputItemsWithResponse(responseId, limit, order, after, before,
@@ -354,11 +357,9 @@ public ResponsesResponse getResponse(String responseId) {
      * @throws RuntimeException all other wrapped checked exceptions if the request fails to be sent.
      * @return the response.
      */
-    @Generated
     @ServiceMethod(returns = ReturnType.SINGLE)
     public ResponsesInputItemList listInputItems(String responseId, int limit, ListInputItemsRequestOrder order,
-        String after, String before) {
-        // Generated convenience method for listInputItemsWithResponse
+                                                       String after, String before) {
         RequestOptions requestOptions = new RequestOptions();
         return listInputItemsWithResponse(responseId, limit, order.toString(), after, before, requestOptions).getValue()
             .toObject(ResponsesInputItemList.class);