Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a .NET 8 target to RequiredTargetFrameworks #46637

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Add a .NET 8 target to RequiredTargetFrameworks #46637

wants to merge 45 commits into from

Conversation

m-redding
Copy link
Member

@m-redding m-redding commented Oct 15, 2024 •
edited
Loading

This PR does the following:

  • Adds a net8.0 target to RequiredTargetFrameworks
  • Temporarily allows API compat checks for net8.0 targets to fall back to netstandard2.0 targets
  • Temporarily removes the generated code and API listings check to avoid a 480,000+ LOC PR and more effectively have changes reviewed
  • Implicitly removes dependencies on BCL packages built into the runtime for .NET 6+ targets

Nullable reference types were not available in netstandard2.0. Many of the changes in this PR are related to nullability. I added comments to other changes pointing to the reasoning behind that change.

Resolves:

Live test status:

Pipeline name Status Link to issue or successful run
net - attestation - tests failed (appears unrelated) #47132
net - batch - tests failed (unrelated) #47142
net - identity - tests failed (unrelated) #47163
net - objectanchors - tests failed (unrelated) #47161
net - openai - tests failed (unrelated) #47170
net - playwrighttesting - tests succeeded https://github.com/Azure/azure-sdk-for-net/runs/33064578251
net - servicebus - functions - tests failed (unrelated) #47168
net - storage - tests failed (unrelated) #47183
net - tables - tests failed (unrelated) #47182
net - translation - tests failed (unrelated) #47165
net - Azure.Monitor.OpenTelemetry.Exporter - tests succeeded pipeline results
net - core - tests succeeded pipeline results
net - eventhub - functions - tests succeeded pipeline results
net - eventhub - tests succeeded pipeline results
net - servicebus - tests succeeded pipeline results

@m-redding m-redding mentioned this pull request Oct 15, 2024
Open
9 tasks
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 21, 2024 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Core.Amqp
Azure.Core.Expressions.DataFactory
Azure.Core
Azure.Provisioning.CloudMachine
Azure.Provisioning
Azure.Identity
Azure.Messaging.EventHubs
Azure.Data.Tables
Azure.Storage.Files.DataLake
Azure.AI.OpenAI
Azure.MixedReality.ObjectAnchors.Conversion
Azure.Messaging.ServiceBus

This was referenced Nov 14, 2024
Open
Open
Open
@m-redding
Copy link
Member Author

/azp run net - core - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@m-redding
Copy link
Member Author

/azp run net - playwrighttesting - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 14, 2024
Open
Open
@m-redding
Copy link
Member Author

/azp run net - storage - tests

@m-redding
Copy link
Member Author

/azp run net - tables - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 15, 2024
Open
Open
jsquire
jsquire approved these changes Nov 15, 2024
View reviewed changes
eng/Directory.Build.Common.props Outdated Show resolved Hide resolved
eng/Directory.Build.Common.props Show resolved Hide resolved
@Sid200026
Copy link
Member

/azp run net - playwrighttesting - tests

@azure-pipelines Azure Pipelines
Copy link

Pull request contains merge conflicts.

@m-redding
Copy link
Member Author

/azp run net - playwrighttesting - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard
weshaggard approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good from engsys perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annelo-msft annelo-msft annelo-msft left review comments

@jsquire jsquire jsquire approved these changes

@weshaggard weshaggard weshaggard approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@JonathanCrd JonathanCrd Awaiting requested review from JonathanCrd JonathanCrd is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@amnguye amnguye Awaiting requested review from amnguye amnguye is a code owner

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft jaschrep-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@nickliu-msft nickliu-msft Awaiting requested review from nickliu-msft nickliu-msft is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina KrzysztofCwalina is a code owner

@Sid200026 Sid200026 Awaiting requested review from Sid200026 Sid200026 is a code owner

@puagarwa puagarwa Awaiting requested review from puagarwa puagarwa is a code owner

@ShreyaAnand ShreyaAnand Awaiting requested review from ShreyaAnand ShreyaAnand is a code owner

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@ralph-msft ralph-msft Awaiting requested review from ralph-msft ralph-msft is a code owner

@cijothomas cijothomas Awaiting requested review from cijothomas

@reyang reyang Awaiting requested review from reyang

@rajkumar-rangaraj rajkumar-rangaraj Awaiting requested review from rajkumar-rangaraj rajkumar-rangaraj is a code owner

@TimothyMothra TimothyMothra Awaiting requested review from TimothyMothra TimothyMothra is a code owner

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@MikeyMCZ MikeyMCZ Awaiting requested review from MikeyMCZ MikeyMCZ is a code owner

@vikaspalaskar vikaspalaskar Awaiting requested review from vikaspalaskar vikaspalaskar is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@dubiety dubiety Awaiting requested review from dubiety dubiety is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@m-redding @azure-sdk @seanmcc-msft @Sid200026 @jsquire @christothes @weshaggard @annelo-msft