Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS-loaders] Stabilize feature #5198

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[JS-loaders] Stabilize feature #5198

wants to merge 22 commits into from

Conversation

dmceachernmsft
Copy link
Member

What

Stabilze JS-loader functions

Why

GA's the feature for GroupMe

How Tested

Built and tested locally CI to validate

@dmceachernmsft dmceachernmsft requested review from a team as code owners September 23, 2024 18:52
@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-nnjukikwix.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 1756740
  • Base size: 1756739
  • Diff size: 1

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-scjnumgjpz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pnzzefhbml.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-xkgjkdmwaq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-yjbuotumuj.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-hvrnilwszu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-azmnjpvqys.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jlfodffezs.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vyxfwrdbyu.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 6 URL https://60c7ae6891f0e90039d7cd54-gpmnzitmgz.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-devmqmzxzu.chromatic.com/

JamesBurnside
JamesBurnside requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@JamesBurnside JamesBurnside left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as request changes for the update to features file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@PorterNan PorterNan PorterNan approved these changes

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@mgamis-msft mgamis-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmceachernmsft @JamesBurnside @PorterNan @mgamis-msft