Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS-loaders] Stabilize feature #5198

Merged
merged 23 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
ba7b105
Stabilize feature
dmceachernmsft Sep 23, 2024
19ef2ec
Change files
dmceachernmsft Sep 23, 2024
4a5fcb9
fix build issue
dmceachernmsft Sep 23, 2024
262bcd2
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 23, 2024
cc6dab9
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 24, 2024
d3fa4f5
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 24, 2024
a06956a
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 25, 2024
6578e42
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 25, 2024
d3f1793
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 25, 2024
6870205
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 26, 2024
755fa95
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 27, 2024
45738b7
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 27, 2024
4996d75
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Sep 27, 2024
b757eea
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 2, 2024
f95295f
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 7, 2024
1192e27
update callComposite API
dmceachernmsft Oct 7, 2024
0ab5218
update API
dmceachernmsft Oct 7, 2024
5e324fd
Merge branch 'main' of https://github.com/Azure/communication-ui-libr…
dmceachernmsft Oct 8, 2024
19a718f
update comments
dmceachernmsft Oct 8, 2024
e8bd389
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 8, 2024
b732e67
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 9, 2024
2b4d579
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 9, 2024
be1b32b
Merge branch 'main' into dmceachernmsft/stabilize-loaders
dmceachernmsft Oct 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "feature",
"workstream": "JavsScript Loaders",
"comment": "Stabilize Javascript Loaders from a sub export of communication react",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "feature",
"workstream": "JavsScript Loaders",
"comment": "Stabilize Javascript Loaders from a sub export of communication react",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion common/config/babel/features.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ module.exports = {
// Feature for showing notifications
"notifications",
// Feature for tracking beta start call identifier
'start-call-beta'
'start-call-beta',
// feature for adding JS helpers to the UI library API
"composite-js-helpers",
dmceachernmsft marked this conversation as resolved.
Show resolved Hide resolved
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { initializeIcons } from '@fluentui/react';

/**
* Props for the OutboundCallComposite that you can use in your application.
dmceachernmsft marked this conversation as resolved.
Show resolved Hide resolved
* @beta
* @public
*/
export type CallCompositeLoaderProps = {
userId: string;
Expand All @@ -35,7 +35,7 @@ export type CallCompositeLoaderProps = {
/**
* Loader function for the OutboundCallComposite that you can use in your application.
dmceachernmsft marked this conversation as resolved.
Show resolved Hide resolved
*
* @beta
* @public
*/
export const loadCallComposite = async function (
adapterArgs: CallCompositeLoaderProps,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { CallWithChatCompositeLoaderProps } from './callWithChatCompositeLoader'
jest.mock('@internal/react-composites', () => {
return {
createAzureCommunicationCallWithChatAdapter: jest.fn().mockResolvedValue('mockAdapter'),
CallWithChatComposite: jest.fn().mockReturnValue('mockCallComposite')
CallWithChatComposite: jest.fn().mockReturnValue('mockCallWithChatComposite')
};
});
const mockCreateRoot = jest.fn();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { initializeIcons } from '@fluentui/react';

/**
* Props for the CallWithChatComposite that you can use in your application.
* @beta
* @public
*/
export type CallWithChatCompositeLoaderProps = {
userId: string;
Expand All @@ -33,7 +33,7 @@ export type CallWithChatCompositeLoaderProps = {

/**
* Props for the CallWithChatComposite that you can use in your application.
* @beta
* @public
*/
export const loadCallWithChatComposite = async function (
args: CallWithChatCompositeLoaderProps,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ChatCompositeLoaderProps } from './chatCompositeLoader';
jest.mock('@internal/react-composites', () => {
return {
createAzureCommunicationChatAdapter: jest.fn().mockResolvedValue('mockAdapter'),
ChatComposite: jest.fn().mockReturnValue('mockCallComposite')
ChatComposite: jest.fn().mockReturnValue('mockChatComposite')
};
});
const mockCreateRoot = jest.fn();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { initializeIcons } from '@fluentui/react';

/**
* Props for the ChatComposite that you can use in your application.
* @beta
* @public
*/
export type ChatCompositeLoaderProps = {
userId: string;
Expand All @@ -32,7 +32,7 @@ export type ChatCompositeLoaderProps = {

/**
* Loader function for the ChatComposite that you can use in your application.
* @beta
* @public
*/
export const loadChatComposite = async function (
args: ChatCompositeLoaderProps,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { initializeIcons } from '@fluentui/react';

/**
* Props for the OutboundCallComposite that you can use in your application.
* @beta
* @public
*/
export type OutboundCallCompositeLoaderProps = {
userId: string;
Expand All @@ -35,7 +35,7 @@ export type OutboundCallCompositeLoaderProps = {
/**
* Loader function for the OutboundCallComposite that you can use in your application.
*
* @beta
* @public
*/
export const loadOutboundCallComposite = async function (
adapterArgs: OutboundCallCompositeLoaderProps,
Expand Down
Loading