Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependabot/249 - cookie npm package needs >= 0.7.0 #5292

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Fix dependabot/249 - cookie npm package needs >= 0.7.0 #5292

merged 6 commits into from
Oct 10, 2024

Conversation

JamesBurnside
Copy link
Member

What

  • Remove unused cookie-parser middleware
  • Update express to LTS that has dependency fix: expressjs/express@2027b87
  • Update storybook so it's dependency has LTS express version
  • Remove obsolete entries in the common-versions files

Why

Fixes https://github.com/Azure/communication-ui-library/security/dependabot/249

How Tested

@JamesBurnside JamesBurnside added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Oct 10, 2024
@JamesBurnside JamesBurnside requested review from a team as code owners October 10, 2024 17:15
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jvcpdjbqgc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11750193
  • Base size: 11750193
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1756786
  • Base size: 1756786
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11750180
  • Base size: 11750180
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 26733 / 43092
62.03%		 26733 / 43092
62.03%		 729 / 1335
54.6%		 2125 / 3403
62.44%
Current 26733 / 43092
62.03%		 26733 / 43092
62.03%		 729 / 1335
54.6%		 2127 / 3403
62.5%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 2 / 0
0.06%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 54004 / 88297
61.16%		 54004 / 88297
61.16%		 1096 / 2484
44.12%		 3195 / 5285
60.45%
Current 54010 / 88297
61.16%		 54010 / 88297
61.16%		 1096 / 2484
44.12%		 3176 / 5272
60.24%
Diff 6 / 0
0%		 6 / 0
0%		 0 / 0
0%		 -19 / -13
-0.21%

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oteqkglrni.chromatic.com/

@JamesBurnside JamesBurnside merged commit 1fc916c into main Oct 10, 2024
39 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/fix-cookie-issue branch October 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlynmac emlynmac emlynmac approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@emlynmac emlynmac

@edwardlee-msft edwardlee-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesBurnside @emlynmac @edwardlee-msft