Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data resources availability #1027

Merged
merged 2 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove webhook configurations
britaniar committed Jan 30, 2025
commit 17abe06e448bdf610483d43338b6e659feb2f2af
4 changes: 0 additions & 4 deletions pkg/controllers/workapplier/availability_tracker.go
Original file line number Diff line number Diff line change
@@ -273,10 +273,6 @@ func isDataResource(gvr schema.GroupVersionResource) bool {
return true
case utils.LimitRangeGVR:
return true
case utils.MutatingWebhookConfigurationGVR:
return true
case utils.ValidatingWebhookConfigurationGVR:
return true
case utils.ResourceQuotaGVR:
return true
case utils.PriorityClassGVR:
13 changes: 0 additions & 13 deletions pkg/controllers/workapplier/availability_tracker_test.go
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ import (

"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
appsv1 "k8s.io/api/apps/v1"
batchv1 "k8s.io/api/batch/v1"
corev1 "k8s.io/api/core/v1"
@@ -957,18 +956,6 @@ func TestTrackInMemberClusterObjAvailabilityByGVR(t *testing.T) {
inMemberClusterObj: toUnstructured(t, &corev1.LimitRange{}),
wantManifestProcessingAvailabilityResultType: ManifestProcessingAvailabilityResultTypeAvailable,
},
{
name: "available mutating webhook configuration",
gvr: utils.MutatingWebhookConfigurationGVR,
inMemberClusterObj: toUnstructured(t, &admissionregistrationv1.MutatingWebhookConfiguration{}),
wantManifestProcessingAvailabilityResultType: ManifestProcessingAvailabilityResultTypeAvailable,
},
{
name: "available validating webhook configuration",
gvr: utils.ValidatingWebhookConfigurationGVR,
inMemberClusterObj: toUnstructured(t, &admissionregistrationv1.ValidatingWebhookConfiguration{}),
wantManifestProcessingAvailabilityResultType: ManifestProcessingAvailabilityResultTypeAvailable,
},
{
name: "available resource quota",
gvr: utils.ResourceQuotaGVR,