-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: deprecated item enforce_private_link_endpoint_network_policies #142
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FridMehdi for opening this pr, this change would be considered as a breaking change so we have to ask for more changes:
- Please rename the current
CHANGELOG.md
file toCHANGELOG-v5.md
- Please create a new, empty
CHANGELOG.md
- Please change the provider's version restriction to:
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">= 3.18.0, < 4.0"
}
}
since this argument was introduced in v3.18.0
.
Thanks for your understanding!
@FridMehdi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@lonegunmanb thanks updated |
update: remove deprecated params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FridMehdi thanks for the update, this pr failed our CI pipeline, would you please rename the module's argument in examples to get them pass the test? I also left a comment on the variable's new name.
Thanks for your help!
variables.tf
Outdated
@@ -47,7 +47,7 @@ variable "subnet_delegation" { | |||
nullable = false | |||
} | |||
|
|||
variable "subnet_enforce_private_link_endpoint_network_policies" { | |||
variable "subnet_enforce_private_endpoint_network_policies_enabled" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new argument's name is private_endpoint_network_policies_enabled
, could we rename this variable to subnet_private_endpoint_network_policies_enabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here
Thanks @FridMehdi for the update, would you please follow the following instrument to sign the agreement to kick off the test? Thanks a lot!
|
Describe your changes
improvment :
Issue number
#000
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!