Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: deprecated item enforce_private_link_endpoint_network_policies #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions CHANGELOG-v5.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Changelog

## [Unreleased](https://github.com/Azure/terraform-azurerm-network/tree/HEAD)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.16.0 to 0.17.0 in /test [\#135](https://github.com/Azure/terraform-azurerm-network/pull/135) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.14.0 to 0.16.0 in /test [\#125](https://github.com/Azure/terraform-azurerm-network/pull/125) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.3.0](https://github.com/Azure/terraform-azurerm-network/tree/5.3.0) (2023-06-06)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.13.0 to 0.14.0 in /test [\#117](https://github.com/Azure/terraform-azurerm-network/pull/117) ([dependabot[bot]](https://github.com/apps/dependabot))
- Add tracing tag toggle variables [\#108](https://github.com/Azure/terraform-azurerm-network/pull/108) ([lonegunmanb](https://github.com/lonegunmanb))
- Bump github.com/Azure/terraform-module-test-helper from 0.9.1 to 0.13.0 in /test [\#106](https://github.com/Azure/terraform-azurerm-network/pull/106) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.2.0](https://github.com/Azure/terraform-azurerm-network/tree/5.2.0) (2023-02-28)

**Merged pull requests:**

- Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /test [\#99](https://github.com/Azure/terraform-azurerm-network/pull/99) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.10 to 0.41.11 in /test [\#98](https://github.com/Azure/terraform-azurerm-network/pull/98) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.8.1 to 0.9.1 in /test [\#97](https://github.com/Azure/terraform-azurerm-network/pull/97) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump golang.org/x/net from 0.1.0 to 0.7.0 in /test [\#96](https://github.com/Azure/terraform-azurerm-network/pull/96) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/hashicorp/go-getter from 1.6.1 to 1.7.0 in /test [\#95](https://github.com/Azure/terraform-azurerm-network/pull/95) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/hashicorp/go-getter/v2 from 2.1.1 to 2.2.0 in /test [\#94](https://github.com/Azure/terraform-azurerm-network/pull/94) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.7.1 to 0.8.1 in /test [\#93](https://github.com/Azure/terraform-azurerm-network/pull/93) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.1.0](https://github.com/Azure/terraform-azurerm-network/tree/5.1.0) (2023-01-28)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.6.0 to 0.7.1 in /test [\#91](https://github.com/Azure/terraform-azurerm-network/pull/91) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.7 to 0.41.9 in /test [\#90](https://github.com/Azure/terraform-azurerm-network/pull/90) ([dependabot[bot]](https://github.com/apps/dependabot))
- Clarify Terraform 1.3 requirement \(fixes \#88\) [\#89](https://github.com/Azure/terraform-azurerm-network/pull/89) ([don-code](https://github.com/don-code))
- Bump github.com/Azure/terraform-module-test-helper from 0.4.0 to 0.6.0 in /test [\#87](https://github.com/Azure/terraform-azurerm-network/pull/87) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 in /test [\#86](https://github.com/Azure/terraform-azurerm-network/pull/86) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.0.0](https://github.com/Azure/terraform-azurerm-network/tree/5.0.0) (2022-12-13)

**Merged pull requests:**

- Make `var.use_for_each` required [\#85](https://github.com/Azure/terraform-azurerm-network/pull/85) ([lonegunmanb](https://github.com/lonegunmanb))



\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
48 changes: 0 additions & 48 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,48 +0,0 @@
# Changelog

## [Unreleased](https://github.com/Azure/terraform-azurerm-network/tree/HEAD)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.16.0 to 0.17.0 in /test [\#135](https://github.com/Azure/terraform-azurerm-network/pull/135) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.14.0 to 0.16.0 in /test [\#125](https://github.com/Azure/terraform-azurerm-network/pull/125) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.3.0](https://github.com/Azure/terraform-azurerm-network/tree/5.3.0) (2023-06-06)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.13.0 to 0.14.0 in /test [\#117](https://github.com/Azure/terraform-azurerm-network/pull/117) ([dependabot[bot]](https://github.com/apps/dependabot))
- Add tracing tag toggle variables [\#108](https://github.com/Azure/terraform-azurerm-network/pull/108) ([lonegunmanb](https://github.com/lonegunmanb))
- Bump github.com/Azure/terraform-module-test-helper from 0.9.1 to 0.13.0 in /test [\#106](https://github.com/Azure/terraform-azurerm-network/pull/106) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.2.0](https://github.com/Azure/terraform-azurerm-network/tree/5.2.0) (2023-02-28)

**Merged pull requests:**

- Bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /test [\#99](https://github.com/Azure/terraform-azurerm-network/pull/99) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.10 to 0.41.11 in /test [\#98](https://github.com/Azure/terraform-azurerm-network/pull/98) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.8.1 to 0.9.1 in /test [\#97](https://github.com/Azure/terraform-azurerm-network/pull/97) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump golang.org/x/net from 0.1.0 to 0.7.0 in /test [\#96](https://github.com/Azure/terraform-azurerm-network/pull/96) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/hashicorp/go-getter from 1.6.1 to 1.7.0 in /test [\#95](https://github.com/Azure/terraform-azurerm-network/pull/95) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/hashicorp/go-getter/v2 from 2.1.1 to 2.2.0 in /test [\#94](https://github.com/Azure/terraform-azurerm-network/pull/94) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/Azure/terraform-module-test-helper from 0.7.1 to 0.8.1 in /test [\#93](https://github.com/Azure/terraform-azurerm-network/pull/93) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.1.0](https://github.com/Azure/terraform-azurerm-network/tree/5.1.0) (2023-01-28)

**Merged pull requests:**

- Bump github.com/Azure/terraform-module-test-helper from 0.6.0 to 0.7.1 in /test [\#91](https://github.com/Azure/terraform-azurerm-network/pull/91) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.7 to 0.41.9 in /test [\#90](https://github.com/Azure/terraform-azurerm-network/pull/90) ([dependabot[bot]](https://github.com/apps/dependabot))
- Clarify Terraform 1.3 requirement \(fixes \#88\) [\#89](https://github.com/Azure/terraform-azurerm-network/pull/89) ([don-code](https://github.com/don-code))
- Bump github.com/Azure/terraform-module-test-helper from 0.4.0 to 0.6.0 in /test [\#87](https://github.com/Azure/terraform-azurerm-network/pull/87) ([dependabot[bot]](https://github.com/apps/dependabot))
- Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 in /test [\#86](https://github.com/Azure/terraform-azurerm-network/pull/86) ([dependabot[bot]](https://github.com/apps/dependabot))

## [5.0.0](https://github.com/Azure/terraform-azurerm-network/tree/5.0.0) (2022-12-13)

**Merged pull requests:**

- Make `var.use_for_each` required [\#85](https://github.com/Azure/terraform-azurerm-network/pull/85) ([lonegunmanb](https://github.com/lonegunmanb))



\* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
2 changes: 1 addition & 1 deletion examples/startup/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ module "network" {
subnet_prefixes = ["10.0.1.0/24", "10.0.2.0/24", "10.0.3.0/24"]
subnet_names = ["subnet1", "subnet2", "subnet3"]

subnet_enforce_private_link_endpoint_network_policies = {
subnet_private_endpoint_network_policies_enabled = {
"subnet1" : true
}
subnet_delegation = {
Expand Down
4 changes: 2 additions & 2 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ resource "azurerm_subnet" "subnet_count" {
name = var.subnet_names[count.index]
resource_group_name = var.resource_group_name
virtual_network_name = azurerm_virtual_network.vnet.name
enforce_private_link_endpoint_network_policies = lookup(var.subnet_enforce_private_link_endpoint_network_policies, var.subnet_names[count.index], false)
private_endpoint_network_policies_enabled = lookup(var.subnet_private_endpoint_network_policies_enabled, var.subnet_names[count.index], false)
service_endpoints = lookup(var.subnet_service_endpoints, var.subnet_names[count.index], [])

dynamic "delegation" {
Expand All @@ -63,7 +63,7 @@ resource "azurerm_subnet" "subnet_for_each" {
name = each.value
resource_group_name = var.resource_group_name
virtual_network_name = azurerm_virtual_network.vnet.name
enforce_private_link_endpoint_network_policies = lookup(var.subnet_enforce_private_link_endpoint_network_policies, each.value, false)
private_endpoint_network_policies_enabled = lookup(var.subnet_private_endpoint_network_policies_enabled, each.value, false)
service_endpoints = lookup(var.subnet_service_endpoints, each.value, [])

dynamic "delegation" {
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ variable "subnet_delegation" {
nullable = false
}

variable "subnet_enforce_private_link_endpoint_network_policies" {
variable "subnet_private_endpoint_network_policies_enabled" {
type = map(bool)
default = {}
description = "A map with key (string) `subnet name`, value (bool) `true` or `false` to indicate enable or disable network policies for the private link endpoint on the subnet. Default value is false."
Expand Down
4 changes: 1 addition & 3 deletions versions.tf
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
terraform {
required_version = ">= 1.3"

required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">= 3.0, < 4.0"
version = ">= 3.18.0, < 4.0"
}
}
}