Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Story promo - visually hidden text update #3136

Merged
merged 3 commits into from
Feb 14, 2020

Conversation

sareh
Copy link
Contributor

@sareh sareh commented Feb 13, 2020

Part of #3125

Overall change: Update visually hidden text to prevent splitting over multiple strings in rendered output - this is useful for when screenreaders read offscreen text - there isn't a break in the text being read out.

Code changes:

  • Update visually hidden text string.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@sareh sareh added ws-home Tasks for the WS Home Team ws-front-page-layout labels Feb 13, 2020
@sareh sareh self-assigned this Feb 13, 2020
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlistairGempf AlistairGempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sareh sareh mentioned this pull request Feb 13, 2020
6 tasks
@sareh sareh merged commit 0ec7c4d into latest Feb 14, 2020
@sareh sareh deleted the story-promo-visually-hidden-text branch February 14, 2020 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-front-page-layout ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants