Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Story promo - visually hidden text update #3136

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Story promo - visually hidden text update #3136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43dc760
Update visually hidden text to prevent splitting over multiple string…
sareh Feb 13, 2020
e8b6788
Update snapshots
sareh Feb 13, 2020
85898c3
Update version
sareh Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-story-promo/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
| ------- | ----------- |
| 4.0.0-alpha.11 | [PR#3136](https://github.com/bbc/psammead/pull/3136) Fix visually hidden text so it isn't split across multiple strings. |
| 4.0.0-alpha.10 | [PR#3129](https://github.com/bbc/psammead/pull/3129) Talos - Bump Dependencies - @bbc/gel-foundations |
| 4.0.0-alpha.9 | [PR#3107](https://github.com/bbc/psammead/pull/3107) Pass in dir prop to MediaIndicator in IndexAlsosContainer. |
| 4.0.0-alpha.8 | [PR#3073](https://github.com/bbc/psammead/pull/3073) Use new major version of MediaIndicator. StoryPromo has updated styling around the MediaIndicator. Index Alsos test helper now using prop `isInline` for the MediaIndicator. |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-story-promo/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-story-promo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-story-promo",
"version": "4.0.0-alpha.10",
"version": "4.0.0-alpha.11",
"main": "dist/index.js",
"module": "esm/index.js",
"sideEffects": false,
Expand Down
6 changes: 2 additions & 4 deletions packages/components/psammead-story-promo/src/IndexAlsos/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ exports[`Index Alsos should render multiple correctly 1`] = `
<span
class="c1"
>
video
,
video,
</span>
<span
class="c8"
Expand Down Expand Up @@ -363,8 +362,7 @@ exports[`Index Alsos should render one correctly 1`] = `
<span
class="c1"
>
video
,
video,
</span>
<span
class="c7"
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-story-promo/src/IndexAlsos/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const IndexAlsosLink = ({
<>
{mediaIndicator}
<RoleText>
<VisuallyHiddenText>{mediaType}, </VisuallyHiddenText>
<VisuallyHiddenText>{`${mediaType}, `}</VisuallyHiddenText>
<IndexAlsosText>{children}</IndexAlsosText>
</RoleText>
</>
Expand Down
6 changes: 2 additions & 4 deletions packages/components/psammead-story-promo/src/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,8 +1367,7 @@ exports[`StoryPromo - Top Story should render with multiple Index Alsos correctl
<span
class="c8"
>
video
,
video,
</span>
<span
class="c15"
Expand Down Expand Up @@ -1753,8 +1752,7 @@ exports[`StoryPromo - Top Story should render with one Index Also correctly 1`]
<span
class="c8"
>
video
,
video,
</span>
<span
class="c14"
Expand Down