client and server: increase p_features size from 1024 to 8192. #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1024 wasn't enough for some CPUs. This caused some hosts to not get sse3 app versions, for example. Note: ideally we'd change this to std::string. But that would have disrupted the code that populates it (hostinfo_unix.cpp, hostinfo_win.cpp). Easier/safer to do it this way.
|
Android and Webassembly are expected to fail, so could be ignored for now |
AenBleidd
requested changes
Mar 4, 2023
AenBleidd
approved these changes
Mar 4, 2023
|
In the current version of the code (master branch), p_features size of the host record is still fixed 1024. That doesn't look right (and probably won't help): https://github.com/BOINC/boinc/blob/master/db/boinc_db_types.h#L369 |
|
@davidpanderson @AenBleidd this probably isn't fixed yet. |
bema-aei
added a commit
to bema-aei/boinc
that referenced
this pull request
Oct 16, 2023
bema-aei
added a commit
to bema-aei/boinc
that referenced
this pull request
Oct 16, 2023
AenBleidd
added a commit
that referenced
this pull request
Oct 16, 2023
complete #5123: client and server: increase p_features size from 1024 to 8192
|
@AenBleidd @davidpanderson does this omission in boinc_db_types affect the server only, or the client as well? |
|
@bema-aei, from what I see in the code, this is for the server only |
|
Server only. Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1024 wasn't enough for some CPUs.
This caused some hosts to not get sse3 app versions, for example.
Note: ideally we'd change this to std::string.
But that would have disrupted the code that populates it (hostinfo_unix.cpp, hostinfo_win.cpp).
Easier/safer to do it this way.
Fixes #5122