Mac: After MacOS update, repair primary groups for users boinc_master, boinc_project

[CharlieFenton]

Fixes #5588 #5910 #5975 #6044

Description of the Change
Every MacOS update changes the primary group of user boinc_master from group boinc_master to staff (20), and changes the primary group of user boinc_project from group boinc_project to staff (20). This PR adds code to fix them when needed. It also adds corresponding code to the command-line utility Mac_SA_Secure.sh.

Alternate Designs
The incorrect primary groups caused problems with use of GPUs which were difficult to diagnose. I implemented #5502 to prevent BOINC from being run with the wrong primary groups by generating permissions error -1301 telling the user to reinstall BOINC. This PR is in response to complaints from users about needing to perform this extra step.

Release Notes
Automatically fix permissions error -1301 on Macs after updating the operating system.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (9)

• client/check_security.cpp: Language not supported
• client/file_names.h: Language not supported
• clientgui/DlgEventLog.h: Language not supported
• clientgui/mac/MacFixUserGroups.cpp: Language not supported
• clientgui/mac/SetupSecurity.cpp: Language not supported
• mac_build/Mac_SA_Secure.sh: Language not supported
• mac_build/boinc.xcodeproj/project.pbxproj: Language not supported
• mac_installer/release_boinc.sh: Language not supported
• mac_installer/release_brand.sh: Language not supported

[CharlieFenton]

Please do not merge yet. I need to do some testing in the next few days.

[NenTech]

Please do not merge yet. I need to do some testing in the next few days.

@CharlieFenton do you want me to test it as well?

[NenTech]

I did build from the mentioned branch. I get the following error:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.95%. Comparing base (2c222cc) to head (87ad9cf).
Report is 140 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6088   +/-   ##
=========================================
  Coverage     11.95%   11.95%           
  Complexity     1068     1068           
=========================================
  Files           280      278    -2     
  Lines         36982    36938   -44     
  Branches       8533     8529    -4     
=========================================
- Hits           4420     4416    -4     
+ Misses        32162    32121   -41     
- Partials        400      401    +1     

see 7 files with indirect coverage changes

[CharlieFenton]

@NenTech Thank you for trying to test, but the changes are more extensive than the BOINC Manager. You need to copy the new Fix_BOINC_Users executable into the BIONC Data folder before running the Mac_SA_Secure.sh script. Even better is to build and run the Mac installer.

[CharlieFenton]

I have now finished testing this PR. It is ready for merging after completing CI checks.

[CharlieFenton]

@NenTech Thank you for trying to test, but the changes are more extensive than the BOINC Manager. You need to copy the new Fix_BOINC_Users executable into the BIONC Data folder before running the Mac_SA_Secure.sh script. Even better is to build and run the Mac installer.

Note that the Mac_SA_Secure.sh script has also bee updated as part of this PR.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

[AenBleidd]

@CharlieFenton, thank you for taking care of this!

[NenTech]

@NenTech Thank you for trying to test, but the changes are more extensive than the BOINC Manager. You need to copy the new Fix_BOINC_Users executable into the BIONC Data folder before running the Mac_SA_Secure.sh script. Even better is to build and run the Mac installer.

I did build the BOINC Manager first and afterwards the installer starting from your branch. But that gave me the error I showed you. I'll try to build again from the master branch now.

[NenTech]

Building from the master succeeded and I am testing the latest merge now.