Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new template, fixed mtbseq template #159

Merged
merged 28 commits into from
Sep 29, 2023

Conversation

GuilleGorines
Copy link
Contributor

MTBSeq template was a little bit suboptimal, I think its better now!
Besides, I added the genomeev template (I swear I was told to do it, if not we can delete it later)

Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisa los comentarios porfi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hay lablog de RESULTS?

Co-authored-by: Pablo Mata <[email protected]>
Comment on lines 1 to 3
test_ref=$(cut -f2 samples_ref.txt | head -n1); if [ "$test_ref" == "NC_045512.2" ]; then rm create_summary_report_metagenomic.sh; mv create_summary_report_sars.sh create_summary_report.sh; else rm create_summary_report_sars.sh; mv create_summary_report_metagenomic.sh create_summary_report.sh; fi
test_ref=$(cut -f2 samples_ref.txt | head -n1); if [ "$test_ref" == "NC_045512.2" ]; then ANALYSIS_TYPE=AMPLICONS; else ANALYSIS_TYPE=METAGENOMIC; fi
test_ref=$(cut -f2 samples_ref.txt | head -n1); if [ "$test_ref" == "NC_045512.2" ]; then CONFIG_FILE=../../DOC/viralrecon_sars.config; else CONFIG_FILE="../../DOC/viralrecon_metagenomic.config"; fi
Copy link
Member

@Shettland Shettland Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sars config might be unnecessary for this pipeline, but im not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was in the same situation so I kept it (you know, this is based on a previous service, and this is the script it used)

Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, good job!!

@GuilleGorines GuilleGorines merged commit 5689e59 into BU-ISCIII:develop Sep 29, 2023
2 checks passed
@GuilleGorines GuilleGorines deleted the develop branch September 29, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants