Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update and bug fixing pre-release 2.0.0 #202

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

Shettland
Copy link
Member

I included several last minute changes to fix some bugs regarding the tools:

  • Included IRMA template to services.json as it was not included
  • Changed the URL from iskylims api to the new one (previously iskylims.isciiides.es)
  • Changed how the service_info.txt is generated during scratch process to allow the script to work even thouhg srun returns exit_status 0 without waiting for the rsync command to finish properly. I will include an issue to handle this in a better way, but right now is functional.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

saramonzon
saramonzon previously approved these changes Mar 1, 2024
@saramonzon saramonzon merged commit f9f46fe into BU-ISCIII:develop Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants