Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in archive module and plasmidID docs #258

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

saramonzon
Copy link
Member

@saramonzon saramonzon commented Apr 25, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

Shettland
Shettland previously approved these changes Apr 25, 2024
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saramonzon saramonzon merged commit e34ec11 into BU-ISCIII:develop Apr 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants