Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created RESULTS/lablog files where needed to include multiqc_report.html #265

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

victor5lm
Copy link
Contributor

@victor5lm victor5lm commented May 17, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

This PR addresses #252.

@victor5lm victor5lm changed the title Created RESULTS/lablog files to include multiqc_report.html Created RESULTS/lablog files where needed to include multiqc_report.html May 17, 2024
@victor5lm victor5lm marked this pull request as ready for review June 14, 2024 14:03
@saramonzon
Copy link
Member

Every service template has a lablog_result that includes multiqc html link? This pr only includes 4, I thought there where more lablogs that needed the change

@victor5lm
Copy link
Contributor Author

I fixed the paths for the symlinks and added a new line in the viralrecon results' lablog, so that a symlink to multiqc_report.html is created in RESULTS for each reference and each host.

@victor5lm victor5lm merged commit 942adad into BU-ISCIII:develop Jun 18, 2024
2 checks passed
@victor5lm victor5lm deleted the multiqc_reports branch September 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants